New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the update process when is out of order #2166

merged 1 commit into from May 31, 2016


None yet
1 participant

gillesbourgeat commented May 31, 2016

When is out of order, it's not possible to launch the update process.

$ php setup/update.php 
PHP Fatal error:  Uncaught exception 'InvalidArgumentException' with message 'Invalid version number provided : 
' in /srv/www/thelia/core/lib/Thelia/Tools/Version/Version.php:116
Stack trace:
#0 /srv/www/thelia/core/lib/Thelia/Install/Update.php(599): Thelia\Tools\Version\Version::parse(false)
#1 /srv/www/thelia/setup/update.php(89): Thelia\Install\Update->getWebVersion()
#2 {main}
  thrown in /srv/www/thelia/core/lib/Thelia/Tools/Version/Version.php on line 116

This pull request fixes this problem.

@gillesbourgeat gillesbourgeat added this to the 2.4.0-alpha1 milestone May 31, 2016

@gillesbourgeat gillesbourgeat merged commit 51c33d4 into thelia:master May 31, 2016

2 checks passed

Scrutinizer No new issues
continuous-integration/travis-ci/pr The Travis CI build passed

Asenar added a commit to Asenar/thelia that referenced this pull request Jun 2, 2016

gillesbourgeat added a commit that referenced this pull request Jun 2, 2016

Merge pull request #2170 from Asenar/fix/array-to-string-conversion-u…

Fix: #2166 array to string conversion when php setup/update.php

gillesbourgeat added a commit to gillesbourgeat/thelia that referenced this pull request Jun 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment