New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not (automatically) expand URLs that have been recently, previously expanded (in the same channel) #3020

Open
Zarthus opened this Issue Feb 2, 2019 · 1 comment

Comments

Projects
None yet
3 participants
@Zarthus
Copy link
Contributor

Zarthus commented Feb 2, 2019

Feature Description

Some bots repeat the URL that was sent (or minify it, to help terminal clients), leading to the same link being expanded twice in a few seconds.

13:08:43 <someguy> highlightedGuy, https://www.youtube.com/watch?v=YlYafmSO3TY
<link gets expanded>
13:08:44 <somebot>  [ Dishonored - Drunken Whaler Lyrics - YouTube ] - https://bit.ly/2HJJYcN
<link gets expanded, again>

This will also prohibit potentially malicious/annoying bots from flooding your messages (many lookups, taking up a lot of space)
img

@xPaw

This comment has been minimized.

Copy link
Member

xPaw commented Feb 4, 2019

I was thinking the server could check last X messages in the channel to find the same link and set shown: false, but that will only work if exactly the same link is sent multiple times.

If different links redirect to the same ending link (like your text example with bit.ly), that will be more tricky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment