Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly append date marker when receiving a message #1002

Merged
merged 1 commit into from Apr 1, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Apr 1, 2017

Chat flexbox revealed a bug we've had since date marker introduction. It would append the date marker inside the text message container, instead of appending after it.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 1, 2017
@xPaw xPaw added this to the 2.3.0 milestone Apr 1, 2017
Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like this is the only place where this change is required. All other places use .before.

Also, it seems that new message marker is not affected. Can you confirm?

@astorije astorije merged commit 44f71bb into master Apr 1, 2017
@astorije astorije deleted the xpaw/append-date-marker branch April 1, 2017 16:59
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Correctly append date marker when receiving a message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants