Only change nick autocompletion when receiving a message #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Bug
xPaw
commented
Sep 4, 2017
| @@ -44,7 +44,7 @@ function appendMessage(container, chanId, chanType, msg) { | |||
|
|
|||
| // Insert date marker if date changed compared to previous message | |||
| if (prevMsgTime.toDateString() !== msgTime.toDateString()) { | |||
| lastChild = $(templates.date_marker({msgDate: msg.time})); | |||
| lastChild = $(templates.date_marker({time: msg.time})); | |||
xPaw
commented
Sep 4, 2017
| time: msg.time, | ||
| previews: [] | ||
| }); | ||
| const newCondensed = $(templates.msg_condensed({time: msg.time})); |
There was a problem hiding this comment.
There's no need to build a complete message since it uses a separate template so we can just optimize it.
AlMcKinlay
approved these changes
Sep 5, 2017
client/js/render.js
Outdated
| @@ -77,12 +73,6 @@ function appendMessage(container, chanId, chanType, msg) { | |||
|
|
|||
| function buildChatMessage(chanId, msg) { | |||
There was a problem hiding this comment.
ChanId should be removed... which will create a fun diff. Feel free to leave it out of this PR for that reason.
There was a problem hiding this comment.
It's called in a single place, so it's easy.
And other minor optimizations and fixes
xPaw
force-pushed
the
xpaw/only-order-autocomplete-on-msg
branch
from
8fa373d
to
e2a122c
Compare
astorije
approved these changes
Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading more history would mess with autocompletion order (it would also sort for each message when loading the page, which is completely unnecessary).