Link to lounge demo from irc badge #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be bias, but 👍 from me. Not everyone looks at the website. Maybe change "#TheLounge channel on freenode" to just "IRC demo" or something? |
|
Yeah, I don't see why not, the demo puts people into #thelounge doesn't it? 2 birds, 1 stone. |
maxpoulin64
added
Type: Feature
|
Yeah sounds good to me too, 👍 |
|
One of the reasons why we couldn't do that on https://github.com/erming/shout was that the demo is connecting to a test IRC server and locked to it. We'll probably want to do that as we attract more users, but in the meantime, this is good enough: 👍. @MaxLeiter, do you mind locking the demo to Freenode, then? |
astorije
added a commit
that referenced
this pull request
Mar 18, 2016
Link to lounge demo from irc badge
|
My bad, I didn't realize it was the case on the demo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a small change for the README