Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Being kicked isn't very intuitive #2266

Closed
lol768 opened this issue Mar 20, 2018 · 7 comments · Fixed by #2647
Closed

Being kicked isn't very intuitive #2266

lol768 opened this issue Mar 20, 2018 · 7 comments · Fixed by #2647
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Milestone
3.0.0

Comments

@lol768
Copy link
Contributor

lol768 commented Mar 20, 2018

Being kicked isn't very intuitive, the input field doesn't disable and the kick message for yourself is collapsed by default. Additionally, issuing /join to rejoin doesn't work, since the channel name isn't assumed from the currently open buffer.

I'd suggest kick messages for yourself should display by default and perhaps the input field should be disabled if you are not in the channel
@lol768
Copy link
Contributor Author

lol768 commented Mar 20, 2018

cc @mbax

@xPaw
Copy link
Member

xPaw commented Mar 22, 2018

Messages that affect the user are no longer collapsed, so that should at least help. #2268

@astorije
Copy link
Member

@lol768, @xPaw, enough to close this issue and mark it as v3?

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Mar 22, 2018
@astorije astorije added this to the 3.0.0 milestone Mar 22, 2018
@MaxLeiter
Copy link
Member

MaxLeiter commented Mar 23, 2018 •
edited

@astorije: I would say

Additionally, issuing /join to rejoin doesn't work, since the channel name isn't assumed from the currently open buffer.

is reason enough to leave it open

@astorije
Copy link
Member

Fair enough!

@MaxLeiter MaxLeiter mentioned this issue Mar 23, 2018
Closed
@lol768
Copy link
Contributor Author

lol768 commented Mar 23, 2018

My bad for not splitting it into two tickets!

@Jay2k1 Jay2k1 mentioned this issue May 28, 2018
Closed
@xPaw
Copy link
Member

xPaw commented Jun 21, 2018

I'll consider this fixed. There's a PR to make /join assume current channel (which isn't directly related to kicks anyway).

@xPaw xPaw closed this as completed Jun 21, 2018
This was referenced Jul 11, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

Port sidebar, chat, user list, state to Vue thelounge/thelounge
4 participants
@astorije @xPaw @lol768 @MaxLeiter