Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add file uploading support #2552
This excites me so much, even though I probably wouldn't use the feature as-is because of the dependency on The Lounge and its instance's address for serving the images. (I'm all about log integrity, and I currently choose what services I use for file uploads very carefully based on what I think has the best chance of still being around in ten years.)
The future may bring writing to a custom uploads directory (on a network mount, for example) and returning a custom URL based on that, so uploads can go somewhere besides The Lounge's server if wanted/needed. Maybe it will even support a few third-party hosts (Imgur, etc.) and/or standalone self-hosted image/file servers (Pomf, ownCloud, etc.) via plugins, who knows.
My point is, much of the truly heavy lifting is already in this PR, and I'm positively tingling with excitement for the future of this function.
Man, it's a great time to be an IRC user. My former IRC friends who've jumped on the Discord bandwagon don't know the Renaissance they're missing! (Even if it is services like Discord that are pushing IRC clients to step up…
Code looks generally good, but I need to do some more testing on actually running it before I approve. I'll hopefully do that tonight. Looking really great, excited to have this in.