Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide Native App settings section when no items are available #2705

Merged
merged 1 commit into from Aug 21, 2018
Merged

Hide Native App settings section when no items are available #2705

merged 1 commit into from Aug 21, 2018

Conversation

MaxLeiter
Copy link
Member

on Safari, there would be a "Native App" header with no options underneath it.

Alternatively, instead of hiding the options, I could set them to disabled and add a tooltip. Thoughts?

@xPaw
Copy link
Member

xPaw commented Aug 18, 2018

This certainly might not work as expected, as webapp-install-button can become visible in an event later on.

@xPaw xPaw added this to the 3.0.0 milestone Aug 21, 2018
@xPaw xPaw merged commit dbd6bee into thelounge:master Aug 21, 2018
@MaxLeiter MaxLeiter deleted the hide-native branch August 21, 2018 19:52
@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xPaw xPaw xPaw approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MaxLeiter @xPaw