New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin/ctcp: Let the user know a CTCP request was sent #3019

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Zarthus
Copy link
Contributor

Zarthus commented Feb 2, 2019

Because responding to a CTCP request is completely optional,
sometimes thelounge will just do absolutely nothing. (the request
was received, but the client did not respond to it)

This alleviates the problem by always notifying the user that
something was sent.


I tested some CLIENTINFOs on myself and the response was * Zarthus CLIENTINFO VERSION - which was a bit confusing to me.


img

@xPaw xPaw added this to the 3.1.0 milestone Feb 2, 2019

@Zarthus Zarthus force-pushed the Zarthus:ctcp_notify branch 3 times, most recently from 184fe09 to c98bddf Feb 2, 2019

@xPaw
Copy link
Member

xPaw left a comment

Can you fix this up for Vue please.

@Zarthus Zarthus force-pushed the Zarthus:ctcp_notify branch 2 times, most recently from f378d89 to 966f7e5 Feb 16, 2019

@Zarthus

This comment has been minimized.

Copy link
Contributor Author

Zarthus commented Feb 16, 2019

Updated: I also changed the nickname to be from "You" to your own nickname. ( TL is xPaw2 in this case, and the remote target client is KindOna )

updated

plugin/ctcp: Let the user know a CTCP request was sent
Because responding to a CTCP request is completely optional,
sometimes thelounge will just do absolutely nothing. (the request
was received, but the client did not respond to it)

This alleviates the problem by always notifying the user that
*something* was sent.

@Zarthus Zarthus force-pushed the Zarthus:ctcp_notify branch from 966f7e5 to 0fbf301 Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment