New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bringing native guilds back to tmwa <alpha> #90

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@Rawng
Contributor

Rawng commented May 10, 2015

What should work:

  Creating a guild with /createguild <name>
  Inviting others with    /guild <name> or /invite <name> or the invite button with guild tab selected
  Leaving a guild with the leave button with guild tab selected
  Guild deletion via all members leaving the guild.
  Guild persistence between logins and server reboots (barring a crash before db save)
@Rawng

This comment has been minimized.

Contributor

Rawng commented May 10, 2015

@wushin @mekolat @nashley

This is not ready for release as required features are still missing and implemented features are somewhat buggy.

This is primarily intended to solicit feedback, help find bugs, get some merge conflicts early and fix any travis build issues.

@wushin wushin added the enhancement label May 12, 2015

@wushin

This comment has been minimized.

Member

wushin commented May 12, 2015

@Rawng I put this on test, but got an error
mapif_parse_GuildInfo : Fatal Error!

Is it missing confs?

@wushin wushin added the On Test label May 12, 2015

@Rawng

This comment has been minimized.

Contributor

Rawng commented May 12, 2015

https://github.com/Rawng/ManaPlus/tree/guild

You can use this branch of Manaplus to test the new guild features.

The only change needed is to edit line 79 in src/net/tmwa/serverfeatures.cpp to 'return true;'

@wushin

This comment has been minimized.

Member

wushin commented May 17, 2015

Nice tested and most things worked. Sometimes you had to log out and back in again for them to take effect. But gj so far. I wish someone else would have been online so I could have tested more.

@wushin wushin removed the On Test label May 18, 2015

@wushin

This comment has been minimized.

Member

wushin commented May 21, 2015

Its always that map clif that seems to be the merge conflict. looks good so far though

@Rawng

This comment has been minimized.

Contributor

Rawng commented May 23, 2015

Guild chat now works

@wushin

This comment has been minimized.

Member

wushin commented May 23, 2015

:D

@wushin wushin added the On Test label May 23, 2015

@Rawng

This comment has been minimized.

Contributor

Rawng commented May 25, 2015

Things fixed:

  • Guild social tab should reflect members logging out
  • Players in a guild can no longer receive further invites
  • Guild social tab should reflect newly added members
  • Players in a guild can no longer create new guilds
  • Requested guild name checked in various ways for validity

TODO:

  • Manaplus does not display the inviting players name to the invitee
    • "has invited you to join the guild " cannot send inviting player's name.
  • Manaplus does not announce new members names in the guild chat tab.
    • "User has joined your guild" -- cannot send user name.
@Rawng

This comment has been minimized.

Contributor

Rawng commented May 30, 2015

Added preliminary script builtin "createguild" takes 1 argument, a string of 24 characters.

@wushin

This comment has been minimized.

Member

wushin commented May 30, 2015

Will the code restrict people from using the /createguild in M+

@Rawng

This comment has been minimized.

Contributor

Rawng commented May 30, 2015

Not yet, but this is planned once creating via npc is known to work right

Once a working npc exists I'd like to have a call for public testing via the forums for more strenuous bug testing, after which work will begin on making various things controlled via config files.

@wushin wushin removed the On Test label Jun 16, 2015

@wushin

This comment has been minimized.

Member

wushin commented Jun 16, 2015

Taking this off test while https://forums.themanaworld.org/viewtopic.php?f=2&t=19064 takes place.

@wushin

This comment has been minimized.

Member

wushin commented Jun 30, 2015

@Rawng we changed something in the core code and now I can't get guild to build.

@Rawng

This comment has been minimized.

Contributor

Rawng commented Jun 30, 2015

@wushin i don't currently have access to a Linux machine to do any development unfortunately. getting Linux on my new laptop is at the top of my priority list though so hopefully I will be able to return soon.

@Rawng

This comment has been minimized.

Contributor

Rawng commented Jun 30, 2015

also if you could post the commit that broke it it will make it easier to fix

@wushin

This comment has been minimized.

Member

wushin commented Jun 30, 2015

@mekolat is investigating as we speak.

@Rawng

This comment has been minimized.

Contributor

Rawng commented Jul 12, 2015

Committed wushin's updates regarding MIN_CLIENT_VERSION, should be up to date for now.

@wushin

This comment has been minimized.

Member

wushin commented Jul 12, 2015

:D

@wushin wushin added the On Test label Jul 24, 2015

@wushin

This comment has been minimized.

Member

wushin commented Jul 30, 2015

@Rawng did you see the new changes @4144 added to M+ for guild badges?

@Rawng

This comment has been minimized.

Contributor

Rawng commented Aug 1, 2015

It looks like there's no way for us to support this for now.

@Rawng

This comment has been minimized.

Contributor

Rawng commented Aug 4, 2015

Added: ability to expel/kick a guild member
Added: script builtin for leaving guild
Fixed: an online/offline state issue

@Rawng Rawng referenced this pull request Aug 4, 2015

Closed

Add guild npc #412

@wushin

This comment has been minimized.

Member

wushin commented Aug 10, 2015

@Rawng is this still stable enough for test?

@Rawng

This comment has been minimized.

Contributor

Rawng commented Aug 22, 2015

  • added packets:
    • smsg_guild_pos_name_list <0x0166>
    • smsg_guild_member_pos_change <0x0156>
    • cmsg_guild_change_member_pos <0x0155>
    • guild position change notify <0x3039>
    • guild position change forward <0x3839>
  • changed 'leader' flag to 'position'
    • Guild Master
      • Invite Member
      • Kick Member
      • Change Position
      • Break Guild
    • Executor
      • Invite Member
      • Kick Member
      • Change Position
    • Officer
      • Invite Member
    • Member
  • changed default position value from 0 to 4 (member)
  • added ability for guild position 2 to kick members
  • don't allow guild leader to be kicked
  • limited inviting players to positions 1, 2, and 3
  • added position change action for positions 1 and 2
  • send guild position change to all map servers
  • reduced MAX_GUILD from 120 to 60
@Rawng

This comment has been minimized.

Contributor

Rawng commented Aug 29, 2015

notes:

  • GM commands added
    • @createguild guild name,guild leader
    • @breakguild guild name
    • @listguildmembers guild name
    • @chngeguildmemberposition guild name,member,position
    • @addtoguild guild name,name
    • @removefromguild guild name,name

@commands with multiple arguments use comma separators, with no spaces between

  • for,example,like,this
@Helianthella

This comment has been minimized.

Contributor

Helianthella commented Aug 31, 2015

@Rawng this will be problematic because char names can have commas in them. Maybe we could use / or | ?

@Rawng

This comment has been minimized.

Contributor

Rawng commented Sep 7, 2015

@mekolat I want aware of that, thanks. Will update someone soon

@wushin

This comment has been minimized.

Member

wushin commented Sep 20, 2015

@Rawng By any chance while doing this have you stumbled on the private chat channels M+ does ? Ping me in IRC so I know where you are at, we've not forgotten about this PR

@wushin wushin removed the On Test label Sep 24, 2015

@wushin

This comment has been minimized.

Member

wushin commented Nov 22, 2015

@Rawng any chance you could work with @pydsigner at LoF at testing & finishing this off to get it merged? LoF is on master TMWA now. They did ask about native guilds. I could help out a bit once I get my gendered chars PR on TMWA test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment