#47 Support inline images #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the patch! Will review asap :) Looks like there's some failing tests. |
|
Yes, it is :( I will fix test tomorrow. |
| @@ -37,11 +40,6 @@ Version 0.4.6 | |||
| Version 0.4.5 | |||
| - Fix for Python 3 support (issue #42, PR #43) (mflaxman) | |||
|
|
|||
| Version 0.4.4 | |||
There was a problem hiding this comment.
Should it be removed now?
There was a problem hiding this comment.
We're limiting the number of versions shown in the README
|
Hi. I fixed tests (thanks for waiting). |
|
Great, thanks :) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I made support for sending inline images (and add
Content-IDheader to any attachments). See related issue: #47If you need any clarifications or code improvements, please, feel free to write me :)
Related links:
http://developer.postmarkapp.com/developer-send-api.html ("Inline image attachments")
https://tools.ietf.org/html/rfc2392
https://www.ietf.org/rfc/rfc1806.txt