Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

With PJAX, the page will refresh once after closing the image's fancybox window #1059

Closed
lei2rock opened this issue Aug 4, 2019 · 3 comments · Fixed by #1111 or #1113
Closed

With PJAX, the page will refresh once after closing the image's fancybox window #1059

lei2rock opened this issue Aug 4, 2019 · 3 comments · Fixed by #1111 or #1113

Comments

@lei2rock
Copy link
Contributor

@lei2rock lei2rock commented Aug 4, 2019

I agree and want to create new issue


Expected behavior

With PJAX, the page will not refresh after closing the image's fancybox window

Actual behavior

see the next part (Steps to reproduce the behavior)

Steps to reproduce the behavior

After adding PJAX support:

  1. visit my pjax test site
  2. click menu item "关于更多"
  3. click the QRcode image to open fancybox window
  4. click "X" to close fancybox window
  5. the page will refresh once

Node.js and NPM Information

v12.1.0
6.10.0

Package dependencies Information

{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "hexo": {
    "version": "3.9.0"
  },
  "dependencies": {
    "hexo": "^3.9.0",
    "hexo-abbrlink": "^2.0.5",
    "hexo-deployer-git": "^1.0.0",
    "hexo-generator-archive": "^0.1.5",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-indexed": "^0.1.1",
    "hexo-generator-searchdb": "^1.0.8",
    "hexo-generator-sitemap": "^1.2.0",
    "hexo-generator-tag": "^0.2.0",
    "hexo-renderer-ejs": "^0.3.1",
    "hexo-renderer-marked": "^1.0.1",
    "hexo-renderer-stylus": "^0.3.3",
    "hexo-server": "^0.3.3",
    "image-size": "^0.7.4"
  }
}

Hexo Information

Hexo version

hexo: 3.9.0
hexo-cli: 2.0.0
os: Darwin 18.7.0 darwin x64
node: 12.1.0
v8: 7.4.288.21-node.16
uv: 1.28.0
zlib: 1.2.11
brotli: 1.0.7
ares: 1.15.0
modules: 72
nghttp2: 1.38.0
napi: 4
llhttp: 1.1.1
http_parser: 2.8.0
openssl: 1.1.1b
cldr: 35.1
icu: 64.2
tz: 2019a
unicode: 12.1

Hexo Configuration

https://github.com/lei2rock/blog/blob/pjax/_config.yml

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

https://github.com/lei2rock/blog/blob/pjax/source/_data/next.yml

Other Information

@lei2rock lei2rock added the Bug label Aug 4, 2019
@stevenjoezhang

This comment has been minimized.

Copy link
Collaborator

@stevenjoezhang stevenjoezhang commented Aug 5, 2019

I guess the hyperlinks used by fancybox are recognized / parsed by PJAX by mistake.

@1v9 1v9 added this to Medium priority in Detected Bugs via automation Aug 5, 2019
@1v9 1v9 closed this in #1111 Aug 19, 2019
Detected Bugs automation moved this from Medium priority to Solved Aug 19, 2019
@lengthmin

This comment has been minimized.

Copy link

@lengthmin lengthmin commented Aug 19, 2019

根据我的测试,还会影响到 back2top 在 sidebar 上的表现。第一遍会加载不出来 back2top 按钮。

@stevenjoezhang

This comment has been minimized.

Copy link
Collaborator

@stevenjoezhang stevenjoezhang commented Aug 19, 2019

@lengthmin 谢谢,已注意到此问题

#1113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Detected Bugs
  
Solved
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.