Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A little bug in cdn [solved] #260

Closed
icecory opened this issue Apr 23, 2018 · 4 comments
Closed

A little bug in cdn [solved] #260

icecory opened this issue Apr 23, 2018 · 4 comments

Comments

@icecory
Copy link

@icecory icecory commented Apr 23, 2018

{% if theme.vendors.Han %}

variable not equal

@icecory icecory changed the title a a little bug in cdn Apr 23, 2018
@sli1989

This comment has been minimized.

Copy link
Collaborator

@sli1989 sli1989 commented Apr 24, 2018

There has corresponding code.

{% if theme.han %}
{% set Han_uri = url_for(theme.vendors._internal + '/Han/dist/han.min.css?v=3.3') %}
{% if theme.vendors.Han %}
{% set Han_uri = theme.vendors.Han %}
{% endif %}
<link rel="stylesheet" media="all" href="{{ Han_uri }}">
{% endif %}

But Don't know the meaning of han.

@icecory

This comment has been minimized.

Copy link
Author

@icecory icecory commented Apr 24, 2018

theme.vendors.Han
should be theme.vendors.han
line 932 : han


belong to
line 858 vendors:
vendors:

@ivan-nginx

This comment has been minimized.

Copy link
Member

@ivan-nginx ivan-nginx commented Apr 24, 2018

Oh! Nice catch, @bitwater1997 👍
Please, guys, fix and reproduce this somebody.

sli1989 pushed a commit that referenced this issue May 2, 2018
Alex LEE
@sli1989

This comment has been minimized.

Copy link
Collaborator

@sli1989 sli1989 commented May 2, 2018

Fixed in 4cacb10.

  • false

0-2

  • true + local lib

1

  • true + theme.vendors.han

1-2

  • true + theme.vendors.Han

1-3

@sli1989 sli1989 closed this May 2, 2018
@sli1989 sli1989 removed the 🐞 Bug Fix label May 2, 2018
@ivan-nginx ivan-nginx changed the title a little bug in cdn A little bug in cdn [solved] Mar 4, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this issue Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.