Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer is overrided by the valine comment in mobile [solved] #48

Closed
sli1989 opened this issue Jan 18, 2018 · 11 comments

Comments

@sli1989
Copy link
Collaborator

commented Jan 18, 2018

I agree and want to create new issue


Actual behavior

qq 20180118222621

Is it possible to be add gap between comment and the footer?

NexT Information

NexT Version:

[x] Latest Master branch.
[] Latest Release version.
[] Old version -

NexT Scheme:

[] All schemes
[x] Muse
[] Mist
[] Pisces
[] Gemini
@tsanie

This comment has been minimized.

Copy link
Contributor

commented Jan 18, 2018

Well, your footer height is too large.
In the default, $footer-height is 50px and the $gap-between-main-and-footer is 100px, the footer height will be up to 150px.

But in your page the footer height, in the desktop layout, is 180px, and in the mobile layout, the height is 208px.

Now you can just change the $footer-height in the file next/source/css/_variables/base.styl.

PS: Maybe there need an option in the theme config file, which allows the users define their own footer-height (like footer.min_height)? @ivan-nginx whats your opinion?

@sli1989

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 18, 2018

yes, thank u. i did add content in the footer page...

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 18, 2018

I think need to:

  1. Check other comment systems (disqus, etc.). If there are works fine, write to Valine repo about bug.
  2. If on other comment systems see the same, then need to see scheme templates. Need to try:
    2.1. Reset all custom footer styles.
    2.2. Test on other schemes (Gemini must have auto footer adjustments, 3 other shemes not).

It's a not critical bug, but need to be fixed.


next/source/css/_variables/base.styl

No. This path for all schemes and for global variables. Need to change footer only for current scheme in:

  • source/css/_mixins/Muse.styl or in
  • source/css/_schemes/Muse/index.styl or in
  • source/css/_variables/Muse.styl.

Base variables what give on all schemes need to edit only if all schemes have same bug. Often was cases, when peoples fix 1 bug for 1 scheme in global vars, but other bug in other schemes will appear after this.


Later i create something like edit instructions on schemes styles.

@tsanie

This comment has been minimized.

Copy link
Contributor

commented Jan 19, 2018

Got it. 👍

But I think his problem is not the comments issues, it's the issue that his footer is too high and covering the main block.

When you fill too many things into the footer, it will cause the issues (except the Gemini scheme).


Steps to reproduce:

  1. Reset all the settings.
  2. Uncomment the footer.custom_text in the theme/_config.yml, and fill texts with several <br/> or some wide words.
  3. Enable a scheme except Gemini.
  4. Start the server and take a look.

image

@sli1989

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 19, 2018

  1. test different scheme
  • in the Mist, there is a clear cut between the comment and footer, the powered by the valine is missing, that might otherwise be obscured. the gap between the comment and footer in my custom page is also clear.

qq 20180119110236
qq 20180119110301

  • in the Pisces, there has still overlapping phenomenon in post and my custom page

qq 20180119110458
qq 20180119110524

  • in the Gemini, it's fine for its auto footer adjustments.

qq 20180119110811
qq 20180119110853

  • test the comment system, there is also have overlapping phenomenon in post and my custom page.

qq 20180119113948
qq 20180119113919


Now i just change the $footer-height to 100px in the file next/source/css/_variables/base.styl, it works.
qq 20180119114346
qq 20180119114329

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 19, 2018

Ok, i think need to add something like auto-height on footer, like on Gemini.

@ivan-nginx ivan-nginx referenced this issue Jan 22, 2018
42 of 72 tasks complete
@sli1989

This comment has been minimized.

Copy link
Collaborator Author

commented Jan 23, 2018

there is no problem using footer.custom_text provided in _config.yml instead of add content in /layout/_partials/footer.swig manually.
BUT when there are too many content in footer, it's still a problem.

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 23, 2018

custom_text: Hosted by <a target="_blank" rel="external nofollow" href="https://pages.github.com">GitHub Pages</a><br>Hosted by <a target="_blank" rel="external nofollow" href="https://pages.github.com">GitHub Pages</a><br>Hosted by <a target="_blank" rel="external nofollow" href="https://pages.github.com">GitHub Pages</a>

image

@stale

This comment has been minimized.

Copy link

commented Mar 24, 2018

This issue has been automatically marked as stale because lack of recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Dec 16, 2018

@sli1989 problem still exists?

@sli1989

This comment has been minimized.

Copy link
Collaborator Author

commented Dec 17, 2018

For me, I know the solutions.
For Next, like u said: Ok, i think need to add something like auto-height on footer, like on Gemini. for the situation: Somebody wants to add too many content in footer.

@ivan-nginx ivan-nginx added this to Needs triage in Detected Bugs via automation Dec 17, 2018
@ivan-nginx ivan-nginx moved this from Needs triage to Low priority in Detected Bugs Dec 17, 2018
@stevenjoezhang stevenjoezhang referenced this issue Dec 30, 2018
7 of 15 tasks complete
Detected Bugs automation moved this from Low priority to Closed Dec 31, 2018
@ivan-nginx ivan-nginx added the Solved label Jan 4, 2019
keepgoingwm added a commit to keepgoingwm/hexo-theme-next that referenced this issue Jan 12, 2019
…into theme-next-master

* 'master' of https://github.com/theme-next/hexo-theme-next: (96 commits)
  Edit Google Analytics reference file address (theme-next#580)
  Fix theme-next#573: [Muse & Mist] Footer is not at the bottom of the page (theme-next#574)
  Update Gitment URL to use jsDelivr CDN (theme-next#572)
  Fix theme-next#569 Valine Comment Count (theme-next#570)
  Improve styles of Gitalk & Gitment  (theme-next#568)
  Optimize the loading of comment systems (theme-next#566)
  Using Template literals (Template strings) (theme-next#557)
  LeanCloud comment counter now loaded faster (theme-next#559)
  styl (theme-next#563)
  Optimize stylesheet (theme-next#561)
  Autoclose issues with keyword.
  Update PULL_REQUEST_TEMPLATE.md
  Release v6.7.0
  update tabs.js
  Update PULL_REQUEST_TEMPLATE.md
  Fix theme-next#48 (theme-next#550)
  New Feature: mhchem support (theme-next#554)
  Fix b2t color for Pisces | Gemini when `b2t: false` false.
  Reduced stale label from 2 to 1 month.
  Fixed b2t to work on all schemes.
  ...

# Conflicts:
#	_config.yml
keepgoingwm added a commit to keepgoingwm/hexo-theme-next that referenced this issue Jan 12, 2019
* theme-next-master: (96 commits)
  Edit Google Analytics reference file address (theme-next#580)
  Fix theme-next#573: [Muse & Mist] Footer is not at the bottom of the page (theme-next#574)
  Update Gitment URL to use jsDelivr CDN (theme-next#572)
  Fix theme-next#569 Valine Comment Count (theme-next#570)
  Improve styles of Gitalk & Gitment  (theme-next#568)
  Optimize the loading of comment systems (theme-next#566)
  Using Template literals (Template strings) (theme-next#557)
  LeanCloud comment counter now loaded faster (theme-next#559)
  styl (theme-next#563)
  Optimize stylesheet (theme-next#561)
  Autoclose issues with keyword.
  Update PULL_REQUEST_TEMPLATE.md
  Release v6.7.0
  update tabs.js
  Update PULL_REQUEST_TEMPLATE.md
  Fix theme-next#48 (theme-next#550)
  New Feature: mhchem support (theme-next#554)
  Fix b2t color for Pisces | Gemini when `b2t: false` false.
  Reduced stale label from 2 to 1 month.
  Fixed b2t to work on all schemes.
  ...
@ivan-nginx ivan-nginx changed the title the footer is overrided by the valine comment in mobile the footer is overrided by the valine comment in mobile [solved] Mar 4, 2019
@ivan-nginx ivan-nginx changed the title the footer is overrided by the valine comment in mobile [solved] Footer is overrided by the valine comment in mobile [solved] Apr 1, 2019
@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Detected Bugs
  
Solved
4 participants
You can’t perform that action at this time.