Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all hardcoded font sizes #1005

Merged
merged 9 commits into from Jul 25, 2019

Conversation

@stevenjoezhang
Copy link
Member

commented Jul 24, 2019

Two steps

  1. Remove all hardcoded font sizes
  2. Use em instead of px

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 Jul 24, 2019
@1v9

This comment has been minimized.

Copy link
Member

commented Jul 24, 2019

Must be the last PR for font-refacctoring 😂

@stevenjoezhang

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

The first one was opened four months ago: #689

@stevenjoezhang stevenjoezhang requested review from 1v9 and jiangtj Jul 24, 2019
@stevenjoezhang stevenjoezhang added this to In progress in Feats. / Imprs. / Fixes via automation Jul 24, 2019
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 24, 2019
@stevenjoezhang

This comment has been minimized.

Copy link
Member Author

commented Jul 24, 2019

Theoretically, this PR does not bring significant visual changes

@stevenjoezhang stevenjoezhang merged commit d944945 into master Jul 25, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Feats. / Imprs. / Fixes automation moved this from In progress to Done Jul 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the font branch Jul 25, 2019
@1v9

This comment has been minimized.

Copy link
Member

commented Jul 25, 2019

post-title h2 这个把我搞晕了,字体太小了

@stevenjoezhang

This comment has been minimized.

Copy link
Member Author

commented Jul 25, 2019

除了Gemini,其它scheme的post-title都设计的比较小

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.