Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntersectionObserver about TOC #1125

Merged
merged 2 commits into from Aug 25, 2019
Merged

IntersectionObserver about TOC #1125

merged 2 commits into from Aug 25, 2019

Conversation

@jiangtj
Copy link
Member

jiangtj commented Aug 24, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
@jiangtj

This comment has been minimized.

Copy link
Member Author

jiangtj commented Aug 24, 2019

Return to the previous title when you slide up
old
image
new
image

When refreshing, navigate to the current title
old
image
new
image

@jiangtj

This comment has been minimized.

Copy link
Member Author

jiangtj commented Aug 24, 2019

master branch: https://jiangtj.gitlab.io/next-test/master/post/many-title/
fix-observer-index branch: https://jiangtj.gitlab.io/next-test/gemini/post/many-title/

Hexo
title0csabrtytnmmsdgvtryhntryjnuy csabrtytnmmsdgvtryhntryjnuy ceabrys,nfrlehgtrlhyt vebytityum,uftmjuy csabrtytnmmsdgvtryhntryjnuy ceabrys,nfrlehgtrlhyt vebytityum,uftmjuy csabrtytnmmsdgvtryhntryjnuy
Hexo
title0csabrtytnmmsdgvtryhntryjnuy csabrtytnmmsdgvtryhntryjnuy ceabrys,nfrlehgtrlhyt vebytityum,uftmjuy csabrtytnmmsdgvtryhntryjnuy ceabrys,nfrlehgtrlhyt vebytityum,uftmjuy csabrtytnmmsdgvtryhntryjnuy
@jiangtj

This comment has been minimized.

Copy link
Member Author

jiangtj commented Aug 24, 2019

还发现个问题,非常快滑动的时候,未观察到
I found another issue, when I slide very quickly, didn’t observe it.

@1v9 1v9 added this to In progress in Feats. / Imprs. / Fixes via automation Aug 24, 2019
@1v9 1v9 added this to the v7.4.0 milestone Aug 24, 2019
@1v9 1v9 changed the title Fix IntersectionObserver index IntersectionObserver about TOC Aug 24, 2019
@1v9 1v9 added 🐞 Bug Fix and removed 🛠 Improvement labels Aug 24, 2019
Feats. / Imprs. / Fixes automation moved this from In progress to Reviewer approved Aug 25, 2019
@1v9
1v9 approved these changes Aug 25, 2019
@1v9 1v9 merged commit 5e2d316 into master Aug 25, 2019
6 checks passed
6 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mergeable Mergeable Run has been Completed!
Details
Tidelift Dependencies checked
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Feats. / Imprs. / Fixes automation moved this from Reviewer approved to Done Aug 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-observer-index branch Aug 25, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.