Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix css of copycode button #238

Merged
merged 1 commit into from Apr 16, 2018

Conversation

@maple3142
Copy link
Member

commented Apr 16, 2018

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Wrong button position after scrolling.
image

Issue Number(s): N/A

What is the new behavior?

Button will be fixed relative to parent.
image

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
@maple3142

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2018

But I find this not working in IE11...
Is there any better way to achieve it?
Example fiddle

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Apr 16, 2018

I think IE11 not support anymore by most web things. Need to support at least Edge, if in Edge worked fine, it's alright.

See details in #30 issue.

@ivan-nginx ivan-nginx added this to the v6.2.0 milestone Apr 16, 2018
@ivan-nginx ivan-nginx merged commit 5cea4ef into theme-next:master Apr 16, 2018
2 checks passed
2 checks passed
Hound No violations found. Woof!
continuous-integration/travis-ci/pr The Travis CI build passed
Details
maboloshi added a commit to maboloshi/hexo-theme-next-1 that referenced this pull request Apr 17, 2018
maboloshi added a commit to maboloshi/hexo-theme-next-1 that referenced this pull request Apr 17, 2018
@stevenjoezhang stevenjoezhang changed the title fix css of copycode button Fix css of copycode button Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.