Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复custom_logo.enable字段无用的BUG;给Gemini和Pisces添加custom_logo支持 #274

Closed
wants to merge 5 commits into from

Conversation

@chenghm123
Copy link

commented May 6, 2018

1、修复custom_logo.enable字段无用的BUG
2、给Gemini和Pisces添加custom_logo支持

2、给Gemini和Pisces添加custom_logo支持
@LEAFERx LEAFERx requested a review from ivan-nginx May 6, 2018
Copy link
Contributor

left a comment

change title and discription to English please.

_config.yml Outdated Show resolved Hide resolved
2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
Copy link
Member

left a comment

It seems default settings was changed in _config.yml.
Please, fix it. And thank's for pull!

haiming.cheng added 2 commits May 6, 2018
2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
@chenghm123

This comment has been minimized.

Copy link
Author

commented May 6, 2018

Sorry! I'm first time pull.

2. Adding custom_logo support of schema Gemini and Pisces.

1. 修复custom_logo.enable字段无用的BUG
2. 给Gemini和Pisces添加custom_logo支持
@sli1989

This comment has been minimized.

Copy link
Collaborator

commented May 14, 2018

Can u re-modify the pr according to the new file where config.title to title, and the added section maybe added before the line12.

{% set title = __('title') !== 'title' && __('title') || config.title %}

@stevenjoezhang stevenjoezhang referenced this pull request Dec 19, 2018
7 of 15 tasks complete
ivan-nginx added a commit that referenced this pull request Dec 21, 2018
* Reorganize #274

* motion

* bug fix
@ivan-nginx ivan-nginx removed the Duplicate label Apr 2, 2019
@stevenjoezhang

This comment has been minimized.

Copy link
Member

commented Aug 21, 2019

Superseded by #520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.