Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine Simplified Chinese Translations and Add Translations for documents in Simplified Chinese. #4

Merged
merged 6 commits into from Jan 2, 2018

Conversation

@Blealtan
Copy link

commented Jan 2, 2018

PR Checklist

  • The commit message follows our guidelines.\

    What are the guidelines on commit message? I can't access the documentation site currently.

  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

  • post/totalcount and post/totaltime in languages/zh-Hans.yml are not translated.
  • Documentations under docs/cn are not translated.

Issue Number(s): N/A

What is the new behavior?

  • Untranslated words in zh-Hans are now translated.

  • Translations for documentations, including DATA-FILES.md, INSTALLATION.md and README.md, are finished.

  • Screens with this changes: N/A

  • Link to demo site with this changes: N/A

How to use?

N/A.

Does this PR introduce a breaking change?

  • Yes.
  • No.
@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

Cool and thank u!
But need to wait a moment: i write additional docs right now, so, can u wait a little and then do full translate of new files?

@Blealtan

This comment has been minimized.

Copy link
Author

commented Jan 2, 2018

Yeah of course. I'll wait for further updates and translate them.

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

It's ready. This commit: 3eebd5f

@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

Fixed, this commit: 3fbb715

@Blealtan

This comment has been minimized.

Copy link
Author

commented Jan 2, 2018

INSTALLATION.md is updated and translation for UPDATE-FROM-5.1.x.md is added. In the translation of the latter one I made some style changes as for Markdown best practices. You may want check it before accepting.

@ivan-nginx ivan-nginx merged commit 15b9652 into theme-next:master Jan 2, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ivan-nginx

This comment has been minimized.

Copy link
Member

commented Jan 2, 2018

Cool dude! Thank's a lot! 👍

@ivan-nginx ivan-nginx added this to the v6.0.0 milestone Jan 2, 2018
ivan-nginx pushed a commit that referenced this pull request Mar 22, 2019
Update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.