Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tag `video` & warn when use `exturl` or `extlink` #652

Merged
merged 3 commits into from Mar 6, 2019

Conversation

@stevenjoezhang
Copy link
Collaborator

stevenjoezhang commented Mar 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
@stevenjoezhang stevenjoezhang mentioned this pull request Mar 4, 2019
stevenjoezhang referenced this pull request in theme-next/theme-next.org Mar 4, 2019
* update docs
@stevenjoezhang stevenjoezhang requested review from ivan-nginx, 1v9, jiangtj and sli1989 Mar 4, 2019
@import "note" if hexo-config('note.style') == 'simple' || hexo-config('note.style') == 'flat';
@import "note-modern" if hexo-config('note.style') == 'modern';
@import "label" if hexo-config('label');

This comment has been minimized.

Copy link
@ivan-nginx

ivan-nginx Mar 4, 2019

Member

It seems need to remove label option from config.

This comment has been minimized.

Copy link
@stevenjoezhang

stevenjoezhang Mar 4, 2019

Author Collaborator

Yes, it's related to theme-next/theme-next.org#18, and won't cause any side effect. The label option only appears once. Considering that we didn't add options for most tags (e.g. button, center-quote, full-image etc.), it would be better to remove it.

This comment has been minimized.

Copy link
@ivan-nginx

This comment has been minimized.

Copy link
@stevenjoezhang

stevenjoezhang Mar 4, 2019

Author Collaborator

Updated, looks fine now

This comment has been minimized.

Copy link
@stevenjoezhang

stevenjoezhang Mar 6, 2019

Author Collaborator

@ivan-nginx Able to merge now?

@stevenjoezhang stevenjoezhang requested a review from ivan-nginx Mar 6, 2019
Copy link
Member

ivan-nginx left a comment

Is quicklink ok there?

@@ -103,7 +103,7 @@
{% block script_extra %}{% endblock %}

{% include '_scripts/next-boot.swig' %}
{% include '_third-party/quicklink/index.swig' %}

This comment has been minimized.

Copy link
@stevenjoezhang

stevenjoezhang Mar 6, 2019

Author Collaborator

Yes, it's fine

@stevenjoezhang stevenjoezhang merged commit c13c804 into theme-next:master Mar 6, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stevenjoezhang stevenjoezhang deleted the GalaxyMimi:optimize branch Mar 6, 2019
@ivan-nginx ivan-nginx added this to In progress in Feats. / Imprs. / Fixes via automation Mar 6, 2019
@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 6, 2019
@1v9 1v9 moved this from In progress to Done in Feats. / Imprs. / Fixes Mar 7, 2019
maboloshi added a commit to maboloshi/hexo-theme-next-1 that referenced this pull request Mar 9, 2019
@liolok liolok changed the title Add warnings to `exturl` tag & Add `video` tag & Code style update Add warnings to `exturl` tag & add `video` tag & update code style Mar 31, 2019
@liolok liolok changed the title Add warnings to `exturl` tag & add `video` tag & update code style New `video` and warn when use `exturl` or `extlink` Mar 31, 2019
@ivan-nginx ivan-nginx changed the title New `video` and warn when use `exturl` or `extlink` New tag `video` & warn when use `exturl` or `extlink` Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.