Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amount option to `tagcloud` #662

Merged
merged 3 commits into from Mar 7, 2019

Conversation

@stevenjoezhang
Copy link
Member

commented Mar 7, 2019

tagcloud:
+  amount: 200

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: iissnan/hexo-theme-next#1908

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
Update
@1v9
1v9 approved these changes Mar 7, 2019
@@ -43,9 +43,9 @@
</div>
<div class="tag-cloud-tags">
{% if not theme.tagcloud %}
{{ tagcloud({min_font: 12, max_font: 30, amount: 300, color: true, start_color: '#ccc', end_color: '#111'}) }}
{{ tagcloud({min_font: 12, max_font: 30, amount: 200, color: true, start_color: '#ccc', end_color: '#111'}) }}

This comment has been minimized.

Copy link
@jiangtj

jiangtj Mar 7, 2019

Member

default 300 -> 200?

@1v9

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

😆 why 200 -> 300 -> 200?

@stevenjoezhang

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

@1v9 @jiangtj iissnan/hexo-theme-next@de271c1, "Temporary" solution for #1908, so change it back...

@1v9

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

I think keep it, or add a statement for tagcloud amount, # if your tags more than 200, you should enable this option and change amount value

Hmmm seems no need to add a statement...

@stevenjoezhang

This comment has been minimized.

Copy link
Member Author

commented Mar 7, 2019

I'll add it to the docs in theme-next.org

@stevenjoezhang stevenjoezhang added this to In progress in Feats. / Imprs. / Fixes via automation Mar 7, 2019
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 7, 2019
@stevenjoezhang stevenjoezhang merged commit 71d5980 into theme-next:master Mar 7, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Feats. / Imprs. / Fixes automation moved this from In progress to Done Mar 7, 2019
@stevenjoezhang stevenjoezhang deleted the PKUPI:tagcloud branch Mar 7, 2019
@ivan-nginx ivan-nginx referenced this pull request Mar 7, 2019
3 of 3 tasks complete
@ivan-nginx ivan-nginx changed the title Fix #1908: Tags amount Added Tags amount option Mar 7, 2019
1v9 added a commit that referenced this pull request Mar 7, 2019
from #662
maboloshi added a commit to maboloshi/hexo-theme-next-1 that referenced this pull request Mar 9, 2019
maboloshi added a commit to maboloshi/hexo-theme-next-1 that referenced this pull request Mar 9, 2019
@liolok liolok changed the title Added Tags amount option Add amount option to `tagcloud` Mar 31, 2019
@liolok liolok changed the title Add amount option to `tagcloud` Amount option to `tagcloud` Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.