Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colored link for modern notes with `exturl` #685

Merged
merged 1 commit into from Mar 14, 2019

Conversation

@stevenjoezhang
Copy link
Member

commented Mar 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #578

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
@stevenjoezhang stevenjoezhang changed the title Fix #578: Fix #578: Link color in modern notes with `exturl` Mar 14, 2019
Copy link
Member

left a comment

Well done!

@stevenjoezhang stevenjoezhang merged commit dcf789d into theme-next:master Mar 14, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stevenjoezhang stevenjoezhang deleted the GalaxyMimi:note branch Mar 14, 2019
mxdh added a commit to mxdh/hexo-theme-next that referenced this pull request Mar 14, 2019
Make the color of exturl link in notes the same as other text (theme-next#685)
@ivan-nginx ivan-nginx changed the title Fix #578: Link color in modern notes with `exturl` Colored link for modern notes with `exturl` Mar 17, 2019
@stevenjoezhang stevenjoezhang added this to the v7.1.0 milestone Mar 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.