Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon option to sidebar chat button #688

Merged
merged 2 commits into from Mar 14, 2019

Conversation

@1v9
Copy link
Member

commented Mar 14, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

the icon of chat button in sidebar is hardcode -> fa-comment

What is the new behavior?

use any icon in fontawesome v4

How to use?

In NexT _config.yml:

# A button to open designated chat widget in sidebar.
# Firstly, you need enable the chat service you want to activate its sidebar button.
chat:
  enable: true
  service: chatra
  #service: tidio
 +icon: comment # icon in Font Awesome4, set false to disable icon
  text: Chat # button text, change it as you wish

Does this PR introduce a breaking change?

  • Yes.
  • No.
1v9 added 2 commits Mar 14, 2019
fiX
@1v9 1v9 requested review from ivan-nginx, maple3142 and stevenjoezhang Mar 14, 2019
1v9 added a commit to theme-next/theme-next.org that referenced this pull request Mar 14, 2019
@1v9 1v9 merged commit 2e34c46 into theme-next:master Mar 14, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@1v9 1v9 deleted the 1v9:chat branch Mar 14, 2019
@ivan-nginx ivan-nginx changed the title add icon option for chat button Added `icon` option for `chat` Mar 16, 2019
@ivan-nginx ivan-nginx added this to In progress in Feats. / Imprs. / Fixes via automation Mar 16, 2019
@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 16, 2019
@ivan-nginx ivan-nginx moved this from In progress to Done in Feats. / Imprs. / Fixes Mar 16, 2019
@liolok liolok changed the title Added `icon` option for `chat` Add `icon` option to `chat` Mar 31, 2019
@liolok liolok changed the title Add `icon` option to `chat` Icon option to sidebar chat button Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.