Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make `site-state-item` centered using `flex` #700

Merged
merged 2 commits into from Mar 17, 2019

Conversation

@stevenjoezhang
Copy link
Collaborator

stevenjoezhang commented Mar 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A
屏幕快照 2019-03-17 上午2 14 52
屏幕快照 2019-03-17 上午2 14 57

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A
    屏幕快照 2019-03-17 上午2 34 41

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
Update
Copy link
Member

ivan-nginx left a comment

Yeah, this is good! Need to moved from floated elements on flex. But flex must be in v7+ only, for v6.x no need adapt flex.

Also, this is looks like Optimization (Refactoring), not like Bugfix.

@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 16, 2019
@ivan-nginx ivan-nginx added this to In progress in Feats. / Imprs. / Fixes via automation Mar 16, 2019
@stevenjoezhang

This comment has been minimized.

Copy link
Collaborator Author

stevenjoezhang commented Mar 17, 2019

屏幕快照 2019-03-17 上午8 45 09
Yes, this should be a v7+ feature, some ancient browsers (about 4%) doesn't support display: flex

@stevenjoezhang stevenjoezhang merged commit ce75c7e into theme-next:master Mar 17, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Feats. / Imprs. / Fixes automation moved this from In progress to Done Mar 17, 2019
@stevenjoezhang stevenjoezhang deleted the GalaxyMimi:state branch Mar 17, 2019
@ivan-nginx ivan-nginx removed the Support label Mar 17, 2019
@ivan-nginx ivan-nginx changed the title Make `site-state-item` centered using `flex` Maked `site-state-item` centered using `flex` Mar 19, 2019
@liolok liolok changed the title Maked `site-state-item` centered using `flex` Make `site-state-item` centered using `flex` Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.