Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Mist & Muse menu bar using `flex` #702

Merged
merged 2 commits into from Mar 17, 2019

Conversation

@stevenjoezhang
Copy link
Member

commented Mar 17, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

屏幕快照 2019-03-17 上午9 20 15
屏幕快照 2019-03-17 上午11 16 05

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A

屏幕快照 2019-03-17 上午9 25 27
屏幕快照 2019-03-17 上午11 27 10
屏幕快照 2019-03-17 上午9 28 15

  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
Update
@stevenjoezhang stevenjoezhang requested review from ivan-nginx and jiangtj Mar 17, 2019
@ivan-nginx ivan-nginx changed the title Refactor Mist & Muse menu bar using `flex` Refactored Mist & Muse menu bar using `flex` Mar 17, 2019
Copy link
Member

left a comment

Not Refactor, but refactored. Because it's not in TODO, but already done (past time).
Same with Fixed, Optimized, etc.

@ivan-nginx ivan-nginx added this to In progress in Feats. / Imprs. / Fixes via automation Mar 17, 2019
@ivan-nginx ivan-nginx added this to the v7.1.0 milestone Mar 17, 2019
@stevenjoezhang stevenjoezhang merged commit c26a5ba into theme-next:master Mar 17, 2019
3 checks passed
3 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Feats. / Imprs. / Fixes automation moved this from In progress to Done Mar 17, 2019
@stevenjoezhang stevenjoezhang deleted the GalaxyMimi:optimize branch Mar 17, 2019
@@ -19,7 +19,7 @@

time {
border-bottom: 1px dashed $grey-dark;
cursor: help;

This comment has been minimized.

Copy link
@ivan-nginx

ivan-nginx Mar 17, 2019

Member

Why u again touch something else?

@ivan-nginx ivan-nginx changed the title Refactored Mist & Muse menu bar using `flex` Refactored Mist & Muse menu bar using `flex` and changed mouse cursor for date at post meta (on pointer, but not pressed) Mar 17, 2019
@ivan-nginx ivan-nginx changed the title Refactored Mist & Muse menu bar using `flex` and changed mouse cursor for date at post meta (on pointer, but not pressed) Refactored Mist & Muse menu bar using `flex` Mar 17, 2019
@liolok liolok changed the title Refactored Mist & Muse menu bar using `flex` Refactor Mist & Muse menu bar using `flex` Mar 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.