Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Refactoring comments #711
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue resolved: N/A
What is the new behavior?
But a lot of testing is needed, and incompatibility with the original configuration can affect many users.
So do you think we should make such a change?
How to use?
+ # Global settings for comments system. + # You can set one type to enable. + # And need to provide additional configurations are required for those types. + # See doc: https://theme-next.org/docs/third-party-services/comments-and-widgets/ + # Example: + # comments: + # type: Disqus # enable disqus. + # count: + # page: true + # post: true + # Additional configurations: + # disqus: + # shortname: shartname + # lazyload: false + comments: + # Type list: + # disqus | disqusjs | changyan | valine | livere | gitment | gitalk | facebook_comments_plugin | vkontakte + type: + # If comment system support, show comments count in meta area + count: + page: true + post: true disqus: - enable: false - count: true disqusjs: - enable: false gitment: - enable: false changyan: - enable: false valine: - enable: false - comment_count: true # if false, comment count will only be displayed in post page, not in home page gitment: - enable: false - count: true gitalk: - enable: false facebook_comments_plugin: - enable: false vkontakte_api - comments: true
Does this PR introduce a breaking change?
Another problem is that some plug-ins provide multiple services, like
# choice your comments service comments_service: # choice your likes service likes_service:
# choice VKontakte provider VKontakte: enable: true # choice Facebook provider Facebook: enable: true
I'm still thinking about how to do it, and I want to use the location of the comment display as a injection point, so that, together with post-meta body-end, the three files under the folder, and the injection method doesn't theoretically break compatibility,
but in this way, I get an array, so the support for the multi-comment system needs to think about it in advance.