Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild ALL-CONTRIBUTORS-LIST in README.md #944

Merged
merged 1 commit into from Jul 4, 2019
Merged

Rebuild ALL-CONTRIBUTORS-LIST in README.md #944

merged 1 commit into from Jul 4, 2019

Conversation

@stevenjoezhang
Copy link
Collaborator

stevenjoezhang commented Jul 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: N/A

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 3, 2019
@stevenjoezhang stevenjoezhang added this to In progress in Feats. / Imprs. / Fixes via automation Jul 3, 2019
@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 Jul 3, 2019
@1v9

This comment has been minimized.

Copy link
Member

1v9 commented Jul 3, 2019

What's this PR for? Seems we have a plan to migrate CONTRIBUTORS to another position.

@stevenjoezhang

This comment has been minimized.

Copy link
Collaborator Author

stevenjoezhang commented Jul 3, 2019

@1v9

This comment has been minimized.

Copy link
Member

1v9 commented Jul 3, 2019

https://github.com/theme-next/hexo-theme-next/blob/readme/README.md#contributors

GitHub
Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.

The style of the first column. . .

@stevenjoezhang

This comment has been minimized.

Copy link
Collaborator Author

stevenjoezhang commented Jul 3, 2019

We can give everyone more badges and make the forms look better 😂

白宫的一个灯泡烧坏了,尼克松按了一下按钮,一个工作人员走进来换了个灯泡。尼克松给了他五美元。
克里姆林宫的一个灯泡坏了,勃列日涅夫的侍卫叫来一名工作人员换了一个灯泡。勃列日涅夫给了他一枚列宁奖章,也给了那名工作人员一枚列宁奖章。勃列日涅夫觉得不错,又给了自己一枚列宁奖章。

@stevenjoezhang stevenjoezhang merged commit 89b8663 into master Jul 4, 2019
4 of 5 checks passed
4 of 5 checks passed
Codacy/PR Quality Review Not up to standards. This pull request quality could be better.
Details
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Feats. / Imprs. / Fixes automation moved this from In progress to Done Jul 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the readme branch Jul 4, 2019
@ivan-nginx

This comment has been minimized.

Copy link
Member

ivan-nginx commented Aug 4, 2019

So, there is the list now?

@stevenjoezhang

This comment has been minimized.

Copy link
Collaborator Author

stevenjoezhang commented Aug 4, 2019

@ivan-nginx Moved to here: https://github.com/theme-next/hexo-theme-next/blob/master/docs/AUTHORS.md

GitHub
Elegant and powerful theme for Hexo. Contribute to theme-next/hexo-theme-next development by creating an account on GitHub.
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.