Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove fastclick support #995

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@stevenjoezhang
Copy link
Member

commented Jul 22, 2019

Breaking change

-fastclick: false
vendors:
-  fastclick:

According to the docs of fastclick:

Note: As of late 2015 most mobile browsers - notably Chrome and Safari - no longer have a 300ms touch delay, so fastclick offers no benefit on newer browsers, and risks introducing bugs into your application. Consider carefully whether you really need to use it.

And:
https://developers.google.com/web/updates/2013/12/300ms-tap-delay-gone-away
https://juejin.im/post/5cdf84e3f265da1bb564c79a

Does this PR introduce a breaking change?

  • Yes.
  • No.
@auto-assign auto-assign bot requested review from ivan-nginx, maple3142 and sli1989 Jul 22, 2019
@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 22, 2019
@stevenjoezhang stevenjoezhang added this to In progress in Feats. / Imprs. / Fixes via automation Jul 22, 2019
@stevenjoezhang stevenjoezhang requested review from 1v9 and jiangtj Jul 22, 2019
@1v9
1v9 approved these changes Jul 22, 2019
Feats. / Imprs. / Fixes automation moved this from In progress to Reviewer approved Jul 22, 2019
@1v9 1v9 merged commit b4cd6e8 into master Jul 23, 2019
5 checks passed
5 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Mergeable Mergeable Run has been Completed!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Feats. / Imprs. / Fixes automation moved this from Reviewer approved to Done Jul 23, 2019
@delete-merged-branch delete-merged-branch bot deleted the fastclick branch Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.