Theme Check Refuse All Shortcode

[turtlepod]

Just Info, I update a theme to wp.org and the result:
https://dl.dropboxusercontent.com/u/32880842/etc2/shortcode-reject.png

I remove shortcodes.php from HC and it's accepted.

So we no longer able to add any shortcode in theme (even for non-content shortcodes).
(it's frustrating, the same with wp_title() stuff.)

[justintadlock]

I'd like to remove them all. Theme Check shouldn't be blocking all shortcodes though.

I'll see if I can get in touch with the TRT about this because this is not something that the team has agreed to do. Right now, Slack is once again down for me and we no longer have the mailing list. It's kind of tough to communicate.

[turtlepod]

actually, after thinking about it. you are right.
it's better to just remove the shortcodes from HC.

it's easier for both HC user and TRT.

[jayj]

But it should still be fixed. Removing shortcodes is not always possible. For example, Cakifo is still using apply_atomic_shortcode and that probably won't change. If this is kept in place, it means I can no longer update Cakifo.

[Rarst]

apply_atomic_shortcode() had been deprecated in Hybrid Core v2 so you are already update blocked on that.

[jayj]

How so?

[Rarst]

There is nothing to use there anymore, so if you want to update to current Core version you'll have to refactor it away anyway.

[jayj]

Cakifo most likely won't be updated so that's not a problem.

[Rarst]

Then I am not following why is removing shortcodes from Core an issue for you? If you refer to general shortcodes situation context with TRT this probably isn't the best place for it. :)

[jayj]

Oh, I meant that the Theme uploader should be fixed, not HC as answer to @turtlepod "it's better to just remove the shortcodes from HC."

Sorry for the confusion

[justintadlock]

Removing shortcodes from HC is something I want to do long term. I just noted it above.

This issue should definitely be fixed in Theme Check. I've reported it, but I and the other TRT admins aren't in control of it. So, we'll have to wait and see.

[justintadlock]

We discussed this for a moment in #themereview on Slack. The tentative decision is to ban all shortcodes, which I'm supportive of. However, there will be time for discussion on this on the Make Themes blog.

As of right now, my plan is to remove all remaining shortcodes regardless of the final decision.

[saas786]

Hi @justintadlock

What about overriding the core shortcodes like Gallery? Which your extension Cleaner Gallery overrides it, will it be not allowed as well? (In theme)?

[justintadlock]

Filtering the gallery hook is different and allowed.

---

Closing this ticket since shortcodes are now gone in the latest on the 2.0 branch.