Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding .editorconfig file #3

Closed
samikeijonen opened this issue Mar 5, 2018 · 5 comments
Closed

Adding .editorconfig file #3

samikeijonen opened this issue Mar 5, 2018 · 5 comments

Comments

@samikeijonen
Copy link
Collaborator

Adding .editorconfig helps developers define and maintain consistent coding styles between different editors and IDEs.

One example of .editorconfig file, probably needs fine tuning.

@justintadlock
Copy link
Member

Cool. I had no idea there was a such thing as .editorconfig.

@samikeijonen
Copy link
Collaborator Author

samikeijonen commented Mar 5, 2018

It took me too long to realize that too. Would have been so much easier to work with other developers in different projects.

justintadlock added a commit that referenced this issue Mar 5, 2018
@m-e-h
Copy link
Collaborator

m-e-h commented Mar 5, 2018

Not sure if WP coding standards are a goal with this theme but if so, here are some things for reference or inclusion:
https://github.com/WordPress/gutenberg/blob/master/.editorconfig
https://github.com/WordPress-Coding-Standards/stylelint-config-wordpress
https://github.com/WordPress-Coding-Standards/eslint-config-wordpress

@samikeijonen
Copy link
Collaborator Author

samikeijonen commented Mar 5, 2018

As long as settings are inline with other sniffs and configs we are going to have. The easiest way is to use WP coding standards as a base, and then create exceptions for that. See also #7 and #8.

@justintadlock
Copy link
Member

We've had this for a while now. We can open new tickets for any specific editor config issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants