Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add css style the recommended way including theme / child theme support. #13

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants

skara commented Feb 20, 2014

Hi again

Here it goes.
CSS as separate file to avoid inline styles.
Included a default css file and possibility to customize an user default style. This is to be located at the users theme folder (child theme supported) to be independent of plugin updates. This could be done even by a simple
@include [path to rpwe]/include/rpwe.css
But there are good reasons not to do so for speed reasons.
The default style is your css just only re-indented for better readability. Using wp_enqueue_style() to let WordPress decide how to handle the css file allows the user to compress it.

I hope you like it and include it into the next update so i don't have to take care of my own hack ;)

Contributor

satrya commented Feb 20, 2014

Actually I already thinking about it(theme/child theme style support), your code looks fine to me. I will review it soon :)

Contributor

satrya commented Apr 23, 2014

Hi, Sorry for long wait. I'll use your method in version 1.0.0.

@satrya satrya closed this Apr 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment