New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with excerpt length #15

Merged
merged 1 commit into from Apr 17, 2014

Conversation

Projects
None yet
3 participants
@andi98
Contributor

andi98 commented Apr 16, 2014

Replaced get_the_excerpt() with get_the_content() in rpwe_excerpt().

Fixed issue #14
Replaced get_the_excerpt() with get_the_content() in rpwe_excerpt().

@andi98 andi98 changed the title from Fixed issue #14 to Fixed issue with excerpt length Apr 16, 2014

@satrya

This comment has been minimized.

Show comment
Hide comment
@satrya

satrya Apr 16, 2014

Contributor

I actually noticed it a few days after I pushed the latest version a live. Thanks for the PR

Contributor

satrya commented Apr 16, 2014

I actually noticed it a few days after I pushed the latest version a live. Thanks for the PR

satrya pushed a commit that referenced this pull request Apr 17, 2014

M.Satrya
Merge pull request #15 from akbyte/master
Fixed issue with excerpt length

@satrya satrya merged commit 1db39fb into themejunkie:master Apr 17, 2014

@jmotes

This comment has been minimized.

Show comment
Hide comment
@jmotes

jmotes Jul 8, 2014

I understand that the original problem this is intending to fix was a too short default excerpt. However, this fix breaks the capability to set a default excerpt - which becomes a major problem if posts include shortcodes, etc. (The shortcodes will show up in the excerpts unprocessed).

IMHO this problem should have been fixed outside of this plugin, using the official recommendations here: http://codex.wordpress.org/Plugin_API/Filter_Reference/excerpt_length

Could you please consider reverting this change so I can continue to show my manually entered excerpts in my news feed? I'll open a bug report and pull request myself if you agree.

jmotes commented Jul 8, 2014

I understand that the original problem this is intending to fix was a too short default excerpt. However, this fix breaks the capability to set a default excerpt - which becomes a major problem if posts include shortcodes, etc. (The shortcodes will show up in the excerpts unprocessed).

IMHO this problem should have been fixed outside of this plugin, using the official recommendations here: http://codex.wordpress.org/Plugin_API/Filter_Reference/excerpt_length

Could you please consider reverting this change so I can continue to show my manually entered excerpts in my news feed? I'll open a bug report and pull request myself if you agree.

@jmotes

This comment has been minimized.

Show comment
Hide comment
@jmotes

jmotes Jul 8, 2014

Nevermind - I'm going ahead and opening a bug report. Let's bring in the discussion at #18 please. Thanks!

jmotes commented Jul 8, 2014

Nevermind - I'm going ahead and opening a bug report. Let's bring in the discussion at #18 please. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment