Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Child page parent hook not found if page name has accents #770

Closed
jlambe opened this issue Mar 11, 2020 · 0 comments
Closed

Child page parent hook not found if page name has accents #770

jlambe opened this issue Mar 11, 2020 · 0 comments
Assignees
Milestone

Comments

@jlambe
Copy link
Contributor

@jlambe jlambe commented Mar 11, 2020

  • Themosis Version: 2.0.5
  • WordPress Version: 5.3.3
  • PHP Version: 7.3

Description

When creating two custom pages with a single / route. If you set the second page as the child of the first page and that your parent page has special/accent characters like é | è | à | ä | and more, the child page hook is not found and its default route is not reachable and displayed.

Steps to reproduce

$meetingPage = Page::make('parent', __('Réunions', APP_TD))
    ->setCapability('edit_posts')
    ->setIcon('dashicons-groups')
    ->setPosition(22)
    ->set();

$meetingPage->route('/', 'App\\Http\\Controllers\\Admin\\Meetings\\MeetingsController@index');

$createPage = Page::make('child', __('Ajouter', APP_TD))
    ->setCapability('edit_posts')
    ->setParent('parent')
    ->set();

$createPage->route('/', 'App\\Http\\Controllers\\Admin\\Meetings\\CreateMeetingController@index');

The $createPage home route is not reached.

Expected behavior

The home route for the child page should be triggered and show its content.

@jlambe jlambe self-assigned this Mar 11, 2020
@jlambe jlambe added this to the 2.0.6 milestone Mar 11, 2020
@jlambe jlambe closed this in 7437a24 Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.