Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Category filtering on click #112

Closed
wants to merge 12 commits into from
Closed

Conversation

Copy link
Collaborator

@Akamitori Akamitori commented Jan 23, 2022

Implemented Category filtering

@Akamitori Akamitori self-assigned this Jan 23, 2022
@zorbathut
Copy link
Contributor

@zorbathut zorbathut commented Jan 24, 2022

Pretty close!

I think this will be better off as a separate page, however. We're going to need to add category-specific stuff to it; we're better off building an actual CategoryPage thing, that contains a PostList and can also contain other things, rather than trying to roll a bunch of category-specific stuff into PostList itself.

This also means that PostList can continue to be dumb and just list the posts given to it, and it's the caller's responsibility to filter them as they see fit.

Also, the URL should end up at /category/{categoryname}.

@zorbathut
Copy link
Contributor

@zorbathut zorbathut commented Feb 20, 2022

Looks mostly good!

One bug: if you go to a category page, then click on a post, it doesn't actually bring you to the post, it just stays at the category page.

@Akamitori
Copy link
Collaborator Author

@Akamitori Akamitori commented Feb 20, 2022

Looks mostly good!

One bug: if you go to a category page, then click on a post, it doesn't actually bring you to the post, it just stays at the category page.

Fixed via ce39f32b1fd0fa46cdc2b90e55fe068120a1bd57

@zorbathut
Copy link
Contributor

@zorbathut zorbathut commented Feb 21, 2022

Looking better! One last issue: when you changed Pages/Components/Post/Default.cshtml it looks like you reformatted it from tabs to spaces. Can you either undo that, or submit the reformat as a separate pull request?

@zorbathut zorbathut closed this Feb 22, 2022
@Akamitori Akamitori deleted the category_filtering branch Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants