New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category filtering on click #112
Conversation
|
Pretty close! I think this will be better off as a separate page, however. We're going to need to add category-specific stuff to it; we're better off building an actual CategoryPage thing, that contains a PostList and can also contain other things, rather than trying to roll a bunch of category-specific stuff into PostList itself. This also means that PostList can continue to be dumb and just list the posts given to it, and it's the caller's responsibility to filter them as they see fit. Also, the URL should end up at |
|
Looks mostly good! One bug: if you go to a category page, then click on a post, it doesn't actually bring you to the post, it just stays at the category page. |
Fixed via ce39f32b1fd0fa46cdc2b90e55fe068120a1bd57 |
|
Looking better! One last issue: when you changed |
Implemented Category filtering