From 12b38e354fdb554a5946a948d348fd9c97ce37e5 Mon Sep 17 00:00:00 2001 From: Robert Kleger Date: Mon, 2 Sep 2019 13:00:56 +0200 Subject: [PATCH 1/2] =?UTF-8?q?=F0=9F=90=9B=20emit=20event=20store=20event?= =?UTF-8?q?=20if=20no=20callback=20is=20provided?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- lib/storeEventEmitter.js | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/lib/storeEventEmitter.js b/lib/storeEventEmitter.js index 3b8d0193..4ca7e8e1 100644 --- a/lib/storeEventEmitter.js +++ b/lib/storeEventEmitter.js @@ -32,14 +32,17 @@ function StoreEventEmitter(eventstore) { * @param {Array} args - arguments from original implementation except callback */ function enhanceCallback(name, callback, args) { - if (callback) { - var originalCallback = callback; + var originalCallback = callback; - callback = function () { - self.eventstore.emit.call(self.eventstore, 'after-' + name, getEmitArguments(args)); + callback = function () { + self.eventstore.emit.call(self.eventstore, 'after-' + name, getEmitArguments(args)); + + if (originalCallback) { return originalCallback.apply(this, arguments); - }; - } + } + + return; + }; return callback; } From d30f378ba37d1628df4dd24a871de20a439ba2f1 Mon Sep 17 00:00:00 2001 From: Robert Kleger Date: Mon, 2 Sep 2019 13:01:33 +0200 Subject: [PATCH 2/2] =?UTF-8?q?=F0=9F=93=9D=20update=20eventstore=20events?= =?UTF-8?q?=20part=20in=20readme?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- README.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 2fe0ab30..6fff8c73 100644 --- a/README.md +++ b/README.md @@ -637,8 +637,8 @@ But if you want you can trigger this from outside: es.on('before-get-snapshot', function({milliseconds, arguments: [query, revMax]}) {}); es.on('after-get-snapshot', function({milliseconds, arguments: [query, revMax]}) {}); - es.on('before-remove-transactions', function({milliseconds}) {}); - es.on('after-remove-transactions', function({milliseconds}) {}); + es.on('before-remove-transactions', function({milliseconds}, arguments: [event]) {}); + es.on('after-remove-transactions', function({milliseconds}, arguments: [event]) {}); es.on('before-get-pending-transactions', function({milliseconds}) {}); es.on('after-get-pending-transactions', function({milliseconds}) {}); @@ -652,20 +652,20 @@ But if you want you can trigger this from outside: es.on('before-stream-events', function({milliseconds, arguments: [query, skip, limit]}) {}); es.on('after-stream-events', function({milliseconds, arguments: [query, skip, limit]}) {}); - es.on('before-stream-events-since', function({milliseconds}) {}); - es.on('after-stream-events-since', function({milliseconds}) {}); + es.on('before-stream-events-since', function({milliseconds, arguments: [date, skip, limit]}) {}); + es.on('after-stream-events-since', function({milliseconds, arguments: [date, skip, limit]}) {}); - es.on('before-get-event-stream', function({milliseconds, parentEventId, arguments: [query, revMin, revMax]}) {}); - es.on('after-get-event-stream', function({milliseconds, parentEventId, arguments: [query, revMin, revMax]}) {}); + es.on('before-get-event-stream', function({milliseconds, arguments: [query, revMin, revMax]}) {}); + es.on('after-get-event-stream', function({milliseconds, arguments: [query, revMin, revMax]}) {}); - es.on('before-get-from-snapshot', function({milliseconds, parentEventId, arguments: [query, revMax]}) {}); - es.on('after-get-from-snapshot', function({milliseconds, parentEventId, arguments: [query, revMax]}) {}); + es.on('before-get-from-snapshot', function({milliseconds, arguments: [query, revMax]}) {}); + es.on('after-get-from-snapshot', function({milliseconds, arguments: [query, revMax]}) {}); - es.on('before-create-snapshot', function({milliseconds, parentEventId, arguments: [obj]}) {}); - es.on('after-create-snapshot', function({milliseconds, parentEventId, arguments: [obj]}) {}); + es.on('before-create-snapshot', function({milliseconds, arguments: [obj]}) {}); + es.on('after-create-snapshot', function({milliseconds, arguments: [obj]}) {}); - es.on('before-commit', function({milliseconds, parentEventId, arguments: [eventstream]}) {}); - es.on('after-commit', function({milliseconds, parentEventId, arguments: [eventstream]}) {}); + es.on('before-commit', function({milliseconds, arguments: [eventstream]}) {}); + es.on('after-commit', function({milliseconds, arguments: [eventstream]}) {}); es.on('before-get-last-event-as-stream', function({milliseconds, arguments: [query]}) {}); es.on('after-get-last-event-as-stream', function({milliseconds, arguments: [query]}) {});