Skip to content
Permalink
Branch: macos-support-…
Commits on Mar 28, 2019
Commits on Mar 8, 2019
  1. MdeModulePkg/HiiImage: Fix stack overflow when corrupted BMP is parse…

    niruiyu authored and lgao4 committed Mar 7, 2019
    …d (CVE-2018-12181)
    
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1135
    
    For 4bit BMP, there are only 2^4 = 16 colors in the palette.
    But when a corrupted BMP contains more than 16 colors in the palette,
    today's implementation wrongly copies all colors to the local
    PaletteValue[16] array which causes stack overflow.
    
    The similar issue also exists in the logic to handle 8bit BMP.
    
    The patch fixes the issue by only copies the first 16 or 256 colors
    in the palette depending on the BMP type.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Ray Ni <ray.ni@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Cc: Jiewen Yao <jiewen.yao@intel.com>
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
  2. MdeModulePkg/HiiDatabase: Fix potential integer overflow (CVE-2018-12…

    niruiyu authored and lgao4 committed Mar 7, 2019
    …181)
    
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1135
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Ray Ni <ray.ni@intel.com>
    Cc: Dandan Bi <dandan.bi@intel.com>
    Cc: Hao A Wu <hao.a.wu@intel.com>
    Reviewed-by: Hao Wu <hao.a.wu@intel.com>
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
  3. Maintainers.txt: remove unexpected unicode BOM

    jwang36 committed Mar 8, 2019
    The BOM was introduced by commit 6c05b95
    accidentally.
    
    Cc: Yao Jiewen <jiewen.yao@intel.com>
    Cc: Zhang, Chao B <chao.b.zhang@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
    Reviewed-by: Zhang, Chao B <chao.b.zhang@intel.com>
  4. Maintainers.txt: Change package maintainer and reviewer of SecurityPkg.

    zhangchaointel committed Mar 8, 2019
    Cc: Yao Jiewen <jiewen.yao@intel.com>
    Cc: Jian Wang <jian.j.wang@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Zhang, Chao B <chao.b.zhang@intel.com>
    Reviewed-by: Jian Wang <jian.j.wang@intel.com>
Commits on Mar 6, 2019
  1. UefiCpuPkg/Microcode.c: Add verification before calculate CheckSum32

    chenc2 authored and niruiyu committed Mar 5, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020
    
    Should make sure the TotalSize of Microcode is aligned with 4 bytes
    before calling CalculateSum32 function.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Eric Dong <eric.dong@intel.com>
  2. BaseTools:Run packagedoc_cli.py to generate doc failed

    zhijufan authored and BobCF committed Mar 1, 2019
    The reason for this problem is that the file was opened incorrectly.
    
    Cc: Bob Feng <bob.c.feng@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
    Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Commits on Mar 1, 2019
  1. UefiCpuPkg/Microcode: Fix InComplete CheckSum32 issue

    chenc2 authored and zhangchaointel committed Feb 28, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1020
    
    The Microcode region indicated by MicrocodePatchAddress PCD may contain
    more than one Microcode entry. We should save InCompleteCheckSum32 value
    for each payload. Move the logic for calculate InCompleteCheckSum32 from
    the outsize of the do-while loop to the inside.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Chen A Chen <chen.a.chen@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Eric Dong <eric.dong@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
  2. UefiCpuPkg: restore strict page attributes via #DB in nonstop mode only

    jwang36 committed Feb 28, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1576
    
    The root cause of this issue is that non-stop mode of Heap Guard and
    NULL Detection set TF bit (single-step) in EFLAG unconditionally in
    the common handler in CpuExceptionLib.
    
    If PcdCpuSmmStaticPageTable is FALSE, the SMM will only create page
    table for memory below 4G. If SMM tries to access memory beyond 4G,
    a page fault exception will be triggered and the memory to access
    will be added to page table so that SMM code can continue the access.
    
    Because of above issue, the TF bit is set after the page fault is
    handled and then fall into another DEBUG exception. Since non-stop
    mode of Heap Guard and NULL Detection are not enabled, no special
    DEBUG exception handler is registered. The default handler just
    prints exception context and go into dead loop.
    
    Actually EFLAGS can be changed in any standard exception handler.
    There's no need to do single-step setup in assembly code. So the fix
    is to move the logic to C code part of page fault exception handler
    so that we can fully validate the configuration and prevent TF bit
    from being set unexpectedly.
    
    Fixes: dcc0262
           16b918b
    Test:
     - Pass special test of accessing memory beyond 4G in SMM mode
     - Boot to OS with Qemu emulator platform (Fedora27, Ubuntu18.04,
       Windows7, Windows10)
    
    Cc: Eric Dong <eric.dong@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Ruiyu Ni <ruiyu.ni@intel.com>
    Cc: Star Zeng <star.zeng@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
    Acked-by: Laszlo Ersek <lersek@redhat.com>
    Reviewed-by: Eric Dong <eric.dong@intel.com>
  3. NetworkPkg: Fix Duplicate FreePool Error in WCM

    fanwang2intel authored and jiaxinwu committed Feb 28, 2019
    * REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1577
    
    In WiFi Connection Manager scan process, the result received
    from WiFi device driver will be freed twice, and will cause
    unexpected errors, and even system crash.
    
    This issue also exists in some other places potentially, this
    patch is to fix these issues and also add Timer Cancelling
    before Close to avoid potential NULL reference.
    
    Cc: Ye Ting <ting.ye@intel.com>
    Cc: Fu Siyuan <siyuan.fu@intel.com>
    Cc: Wu Jiaxin <jiaxin.wu@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Wang Fan <fan.wang@intel.com>
    Reviewed-by: Fu Siyuan <siyuan.fu@intel.com>
    Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
  4. BaseTools: Add python3-distutils Ubuntu package checking

    BobCF committed Feb 28, 2019
    https://bugzilla.tianocore.org/show_bug.cgi?id=1509
    
    Add python3-distutils Ubuntu package checking.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Bob Feng <bob.c.feng@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
    Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
Commits on Feb 28, 2019
  1. IntelFrameworkModulePkg/FwVolDxe: Ensure FfsFileHeader 8 bytes aligned

    lzeng14 authored and jwang36 committed Jan 5, 2018
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=864
    REF: CVE-2018-3630
    
    To follow PI spec, ensure FfsFileHeader 8 bytes aligned.
    
    Current code only handles (FwVolHeader->ExtHeaderOffset != 0) path,
    update code to also handle (FwVolHeader->ExtHeaderOffset == 0) path.
    
    Cc: Jiewen Yao <jiewen.yao@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Star Zeng <star.zeng@intel.com>
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
  2. MdeModulePkg/DxeCore: Ensure FfsFileHeader 8 bytes aligned

    lzeng14 authored and jwang36 committed Jan 5, 2018
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=864
    REF: CVE-2018-3630
    
    To follow PI spec, ensure FfsFileHeader 8 bytes aligned.
    
    For the integrity of FV(especially non-MemoryMapped FV) layout,
    let CachedFv point to FV beginning, but not (FV + FV header).
    
    And current code only handles (FwVolHeader->ExtHeaderOffset != 0) path,
    update code to also handle (FwVolHeader->ExtHeaderOffset == 0) path.
    
    Cc: Jiewen Yao <jiewen.yao@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Cc: Hao Wu <hao.a.wu@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Star Zeng <star.zeng@intel.com>
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
  3. MdeModulePkg/PeiCore: Ensure FfsFileHeader 8 bytes aligned

    lzeng14 authored and jwang36 committed Jan 5, 2018
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=864
    REF: CVE-2018-3630
    
    To follow PI spec, ensure FfsFileHeader 8 bytes aligned.
    
    Current code only handles (FwVolHeader->ExtHeaderOffset != 0) path,
    update code to also handle (FwVolHeader->ExtHeaderOffset == 0) path.
    
    Cc: Jiewen Yao <jiewen.yao@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Cc: Hao Wu <hao.a.wu@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Star Zeng <star.zeng@intel.com>
    Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
  4. Revert "BaseTools:BaseTools supports to the driver combination."

    lgao4 committed Feb 25, 2019
    This reverts commit 838bc25.
    After further evaluation, there are the unclear behavior in for the
    driver combination feature. To not impact Q1 stable tag, remove it first.
    1. If the drivers to be combined have the different PCD or library instance
       setting, build should not combine them and report build break. But this
       commit doesn't consider this case.
    2. When start the sub driver fail, continue to start other sub driver. This
       behavior is required to be clarifed in build spec.
    3. Unload the sub driver when the combined driver start fail. This case need
       to call the sub driver unload function for the driver start fail only.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Liming Gao <liming.gao@intel.com>
    Reviewed-by: Bob Feng <bob.c.feng@intel.com>
  5. NetworkPkg: Add WiFi Connection Manager to NetworkPkg

    fanwang2intel authored and lgao4 committed Feb 22, 2019
    * V2
    
    * Remove Arch dependency in Inf file
    * Add a global guid for WiFi formset and set other guids to module levels
    * Open supplicant and EapConfig by BY_DRIVER
    * Remove token free function to avoid potential NULL reference
    * Update WifiMgrUpdateConnectMessage() to only display message for Current Nic
    * Fix the potential NULL reference in AIP call
    
    * REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1492
    
    Add WiFi Connection Manager in NetworkPkg to provide UI for users to scan
    networks, connect or disconnect to networks.
    
    This connection manager won't include the UNDI driver, supplicant driver,
    or other device specific drivers and is therefor not a complete solution
    stack for UEFI Wi-Fi, users can seek help for Wireless card vendors.
    
    Cc: Ye Ting <ting.ye@intel.com>
    Cc: Fu Siyuan <siyuan.fu@intel.com>
    Cc: Wu Jiaxin <jiaxin.wu@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Wang Fan <fan.wang@intel.com>
    Reviewed-by: Wu Jiaxin <jiaxin.wu@intel.com>
    Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
  6. UefiCpuPkg/PiSmmCpu: Add Shadow Stack Support for X86 SMM.

    jyao1 authored and lgao4 committed Feb 22, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521
    
    We scan the SMM code with ROPgadget.
    http://shell-storm.org/project/ROPgadget/
    https://github.com/JonathanSalwan/ROPgadget/tree/master
    This tool reports the gadget in SMM driver.
    
    This patch enabled CET ShadowStack for X86 SMM.
    If CET is supported, SMM will enable CET ShadowStack.
    SMM CET will save the OS CET context at SmmEntry and
    restore OS CET context at SmmExit.
    
    Test:
    1) test Intel internal platform (x64 only, CET enabled/disabled)
    Boot test:
    CET supported or not supported CPU
    on CET supported platform
      CET enabled/disabled
      PcdCpuSmmCetEnable enabled/disabled
      Single core/Multiple core
      PcdCpuSmmStackGuard enabled/disabled
      PcdCpuSmmProfileEnable enabled/disabled
      PcdCpuSmmStaticPageTable enabled/disabled
    CET exception test:
      #CF generated with PcdCpuSmmStackGuard enabled/disabled.
    Other exception test:
      #PF for normal stack overflow
      #PF for NX protection
      #PF for RO protection
    CET env test:
      Launch SMM in CET enabled/disabled environment (DXE) - no impact to DXE
    
    The test case can be found at
    https://github.com/jyao1/SecurityEx/tree/master/ControlFlowPkg
    
    2) test ovmf (both IA32 and X64 SMM, CET disabled only)
    test OvmfIa32/Ovmf3264, with -D SMM_REQUIRE.
      qemu-system-x86_64.exe -machine q35,smm=on -smp 4
        -serial file:serial.log
        -drive if=pflash,format=raw,unit=0,file=OVMF_CODE.fd,readonly=on
        -drive if=pflash,format=raw,unit=1,file=OVMF_VARS.fd
    QEMU emulator version 3.1.0 (v3.1.0-11736-g7a30e7adb0-dirty)
    
    3) not tested
    IA32 CET enabled platform
    
    Cc: Eric Dong <eric.dong@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Yao Jiewen <jiewen.yao@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
    Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
  7. UefiCpuPkg/ExceptionLib: Add CET support.

    jyao1 authored and lgao4 committed Feb 22, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521
    
    Add information dump for Control Protection exception.
    
    Cc: Eric Dong <eric.dong@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Yao Jiewen <jiewen.yao@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
    Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
  8. MdePkg/BaseLib: Add Shadow Stack Support for X86.

    jyao1 authored and lgao4 committed Feb 22, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521
    
    This patch adds SSP - shadow stack pointer to JumpBuffer.
    It will be used for the platform that enabled CET/ShadowStack.
    
    We add gEfiMdePkgTokenSpaceGuid.PcdControlFlowEnforcementPropertyMask
    to control the global enable/disable.
    
    Cc: Michael D Kinney <michael.d.kinney@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Cc: Eric Dong <eric.dong@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Yao Jiewen <jiewen.yao@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
    Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
  9. MdePkg/Include: Add Nasm.inc

    jyao1 authored and lgao4 committed Feb 22, 2019
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1521
    
    This is to add CET related instruction in Nasm
    because CET instruction is not supported yet.
    
    See https://www.nasm.us/xdoc/2.14.02/html/nasmdocb.html
    
    Cc: Michael D Kinney <michael.d.kinney@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Cc: Eric Dong <eric.dong@intel.com>
    Cc: Ray Ni <ray.ni@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Yao Jiewen <jiewen.yao@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
    Regression-tested-by: Laszlo Ersek <lersek@redhat.com>
  10. NetworkPkg/DnsDxe: [CVE-2018-12178] Check the received packet size be…

    jiaxinwu committed Jul 2, 2018
    …fore parsing the message.
    
    Fix CVE-2018-12178
    REF: https://bugzilla.tianocore.org/show_bug.cgi?id=809
    
    The DNS driver only checks the received packet size against the
    minimum DNS header size in DnsOnPacketReceived(), later it accesses
    the QueryName and QuerySection beyond the header scope, which might
    cause the pointer within DNS driver points to an invalid entry or
    modifies the memory content beyond the header scope.
    
    This patch is to fix above problem.
    
    Cc: Ye Ting <ting.ye@intel.com>
    Cc: Fu Siyuan <siyuan.fu@intel.com>
    Cc: Wang Fan <fan.wang@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.0
    Signed-off-by: Wu Jiaxin <jiaxin.wu@intel.com>
    Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>
  11. MdeModulePkg/RamDiskDxe: Restrict on RAM disk size (CVE-2018-12180)

    hwu25 committed Feb 7, 2018
    REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1134
    
    Originally, the block size of created Ram disks is hard-coded to 512
    bytes. However, if the total size of the Ram disk is not a multiple of 512
    bytes, there will be potential memory access issues when dealing with the
    last block of the Ram disk.
    
    This commit will adjust the block size of the Ram disks to ensure that the
    total size is a multiple of the block size.
    
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Cc: Star Zeng <star.zeng@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Hao Wu <hao.a.wu@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
  12. MdeModulePkg/PartitionDxe: Ensure blocksize holds MBR (CVE-2018-12180)

    hwu25 committed Feb 9, 2018
    REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1134
    
    The commit adds checks for detecting GPT and MBR partitions.
    
    These checks will ensure that the device block size is big enough to hold
    an MBR (512 bytes).
    
    Cc: Jian J Wang <jian.j.wang@intel.com>
    Cc: Star Zeng <star.zeng@intel.com>
    Cc: Laszlo Ersek <lersek@redhat.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Hao Wu <hao.a.wu@intel.com>
    Reviewed-by: Ray Ni <ray.ni@intel.com>
Commits on Feb 27, 2019
  1. ShellBinPkg: Ia32/X64 Shell binary update.

    niruiyu committed Feb 27, 2019
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Ray Ni <ray.ni@intel.com>
  2. BaseTools:The BOM character is processed when python reads a file

    zhijufan authored and BobCF committed Feb 26, 2019
    When python3 reads an XML file it will parse the file in error
    if the file has a BOM
    
    Cc: Bob Feng <bob.c.feng@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
    Reviewed-by: Bob Feng <bob.c.feng@intel.com>
Commits on Feb 26, 2019
  1. Revert "DynamicTablesPkg: Fix protocol section"

    samimujawar committed Feb 25, 2019
    This reverts commit bde673b.
    
    Reverting this patch as Soft Feature Freeze for
    edk2-stable201903 started on 22 Feb 2019.
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Alexei Fedorov <alexei.fedorov@arm.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reviewed-by: Alexei Fedorov <alexei.fedorov@arm.com>
  2. Revert "DynamicTablesPkg: Rename enum used for ID Mapping"

    samimujawar committed Feb 25, 2019
    This reverts commit 1d49a75.
    
    Reverting this patch as Soft Feature Freeze for
    edk2-stable201903 started on 22 Feb 2019.
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Alexei Fedorov <alexei.fedorov@arm.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reviewed-by: Alexei Fedorov <alexei.fedorov@arm.com>
  3. Revert "DynamicTablesPkg: Add OEM Info"

    samimujawar committed Feb 25, 2019
    This reverts commit c788bda.
    
    Reverting this patch as Soft Feature Freeze for
    edk2-stable201903 started on 22 Feb 2019.
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Alexei Fedorov <alexei.fedorov@arm.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reviewed-by: Alexei Fedorov <alexei.fedorov@arm.com>
  4. Revert "DynamicTablesPkg: DGB2: Update DBG2_DEBUG_PORT_DDI"

    samimujawar committed Feb 25, 2019
    This reverts commit 6814256.
    
    Reverting this patch as Soft Feature Freeze for
    edk2-stable201903 started on 22 Feb 2019.
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Alexei Fedorov <alexei.fedorov@arm.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reviewed-by: Alexei Fedorov <alexei.fedorov@arm.com>
  5. Revert "DynamicTablesPkg: Remove GIC Distributor Id field"

    samimujawar committed Feb 25, 2019
    This reverts commit d3a15f4.
    
    Reverting this patch as Soft Feature Freeze for
    edk2-stable201903 started on 22 Feb 2019.
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Alexei Fedorov <alexei.fedorov@arm.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reviewed-by: Alexei Fedorov <alexei.fedorov@arm.com>
  6. Revert "DynamicTablesPkg: Minor updates and fix typos"

    samimujawar committed Feb 25, 2019
    This reverts commit 07f4e26.
    
    Reverting this patch as Soft Feature Freeze for
    edk2-stable201903 started on 22 Feb 2019.
    
    Cc: Laszlo Ersek <lersek@redhat.com>
    Cc: Alexei Fedorov <alexei.fedorov@arm.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reviewed-by: Alexei Fedorov <alexei.fedorov@arm.com>
  7. ArmPkg: Fix writes to GICv3 GICD_IROUTER<n> reg

    samimujawar authored and ardbiesheuvel committed Feb 22, 2019
    According to ARM Generic Interrupt Controller Architecture
    Specification, GIC architecture version 3.0 and version 4.0,
    GICD_IROUTER<n> is a 64-bit register.
    
    Fixed code to use 64 bit MMIO write operations so that the
    Aff3 value (bits [39:32]) is written to GICD_IROUTER<n>.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
    Reported-by: Carl van Schaik <carl@cog.systems>
    Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
  8. EmbeddedPkg/VirtualRealTimeClockLib: Fix correctness issues

    pbatard authored and ardbiesheuvel committed Feb 25, 2019
    LibGetTime():
    - Two variables were used for the epoch, where only one should have been [*].
    - Also harmonize variable name to match the one used in LibSetTime.
    LibSetTime():
    - Address possible underflows if time is set to start of epoch.
    - Ensure that time being read does actually match time that was manually
      set (plus the time elapsed since), by subtracting number of seconds
      since reset.
    
    [*] This fixes a build breakage, since one of these variables was set but
        never used, triggering a compiler diagnostic at some optimization levels.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Pete Batard <pete@akeo.ie>
    Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
  9. BaseTools:PackageDocumentTools import lib error occurs.

    zhijufan authored and BobCF committed Feb 25, 2019
    Steps:
     1. Download edk2 tree
     2. Build BaseTools
     3. Go to edk2\BaseTools\Scripts\PackageDocumentTools
        to run packagedoc_cli.py
    
    An error occurs if relative imports are used when running
    a file alone
    
    Cc: Bob Feng <bob.c.feng@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Zhiju.Fan <zhijux.fan@intel.com>
    Reviewed-by: Bob Feng <bob.c.feng@intel.com>
  10. BaseTools: Fix a Eot issue.

    BobCF committed Feb 25, 2019
    FirmwareVolume.UnDispatchedFfsDict is mutated during iteration,
    convert the FirmwareVolume.UnDispatchedFfsDict.keys() to a new list
     to resolve this problem.
    
    Contributed-under: TianoCore Contribution Agreement 1.1
    Signed-off-by: Bob Feng <bob.c.feng@intel.com>
    Cc: Liming Gao <liming.gao@intel.com>
    Reviewed-by: Liming Gao <liming.gao@intel.com>
Older
You can’t perform that action at this time.