Permalink
Switch branches/tags
Commits on Oct 16, 2012
  1. Add MIT license notice

    thenigan committed Oct 16, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Mar 14, 2012
  1. Fix error in copy from working tree

    thenigan committed Mar 14, 2012
    Commit eacde87 introduced a bug that caused files from the working
    tree to be copied to the incorrect location in the tmp directory. This
    affected any file that was not located at the root of the working tree.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  2. Fix implementation of the cleanup trap for Windows

    thenigan committed Mar 14, 2012
    Prior to this commit, the cleanup trap that removes the tmp dir
    created by the script would fail on Windows. The error was silently
    ignored by the script.
    
    On Windows, a directory cannot be removed while it is the working
    directory of the process (thanks to Johannes Sixt on the Git list
    for this info [1]).
    
    This commit eliminates the 'cd' into the tmp directory that was
    causing the cleanup error.
    
    [1]: http://article.gmane.org/gmane.comp.version-control.git/193086
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Mar 13, 2012
  1. Refactor while loop used to populate tmp/right_dir

    thenigan committed Mar 13, 2012
    There were 3 instances of a 'while read; do' that used identical logic.
    This commit group them into a single loop.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  2. Teach diffall to handle working copy changes without using tar

    thenigan committed Mar 13, 2012
    The 'tar' utility is not available on all platforms (some only support
    'gnutar').  An earlier commit created a work-around for this problem,
    but a better solution is to eliminate the use of 'tar' completely.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  3. Teach diffall to create tmp dirs without using mktemp

    thenigan committed Mar 13, 2012
    mktemp is not available on all platforms.  Instead of littering the code
    with a work-around, this commit replaces mktemp with a one-line Perl
    script.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  4. Change comment to reflect actual reason for 'cdup'

    thenigan committed Mar 13, 2012
    The comment from an earlier commit did not reflect the actual reason this
    operation is needed.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Feb 27, 2012
  1. Documented that '--' is mandatory if a pathspec is given

    thenigan committed Feb 27, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Feb 24, 2012
  1. Remove bashism in '--extcmd=<command>' comparison

    thenigan committed Feb 24, 2012
    'test $# == 1` is a bashism
    'test $# = 1' should be used instead
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  2. Changed test for '--extcmd=<command>' to use $#

    thenigan committed Feb 24, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  3. Documented '--extcmd' in the README

    thenigan committed Feb 24, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  4. Changed 'path_sep' to 'dashdash_seen'

    thenigan committed Feb 24, 2012
    A reviewer commented that the name 'path_sep' "makes one wonder 'are we
    somehow talking about the difference between / vs \ here?'  In other
    parts of the system, this is typically called 'dashdash_seen'".
    
    The name was changed to match local conventions.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  5. Corrected location of hard-coded tmp directory

    thenigan committed Feb 24, 2012
    In commit 1959a18, the leading '/tmp' was mistakenly dropped
    from the hard-coded tmp dir location.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Feb 23, 2012
  1. Files with spaces in their names are now properly supported

    thenigan committed Feb 23, 2012
    In earlier versions, if a file name had spaces it would silently fail
    due to improper quoting in 'git ls-tree' commands.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  2. Removed spaces after redirection operator

    thenigan committed Feb 23, 2012
    Change made based on feedback from patch review on git developers list.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  3. Verify that user supplied a command for --extcmd

    thenigan committed Feb 23, 2012
    If the user executed "git diffall --extcmd", it would result in a shift
    error with no useful message to the user.
    
    The script now verifies that a command was specified after --extcmd if
    it is the last option on the command-line.  If it fails, an error
    message and usage instructions are displayed.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  4. Cleaned up README

    thenigan committed Feb 23, 2012
    Changed "The script is compatible with all forms" to "most common forms"
    used to specify a commit range for diff.
    
    Added line breaks for long lines.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  5. Renamed "common_ancestor" to "merge_base"

    thenigan committed Feb 23, 2012
    During patch review on the git list, it was pointed out that diffing
    <commit>...<commit> is not just a common ancestor, but but a merge base.
    
    A merge base is "a common ancestor none of whose children is a common
    ancestor".
    
    The variable was renamed to try and make this more clear.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  6. Improved robustness of tmp dir creation

    thenigan committed Feb 23, 2012
    During a review of this script on the git developers list, it was pointed
    out that using a fixed tmp dir name could result in name crashes.
    
    Adding '$$' to the dir name will provide some protection.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Feb 22, 2012
  1. Fixed more indentation errors

    thenigan committed Feb 22, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  2. Cleaned up trap function so it actually runs on abnormal exit

    thenigan committed Feb 22, 2012
    In earlier versions, trap was not set until the last line of the script.
    This prevented it from executing on any abnormal exits.  It must be set
    up *before* it is needed.  This version also moves the '--copy-back'
    feature to the end of normal execution rather than making it part of the
    exit trap.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  3. Eliminated use of 'which' statements

    thenigan committed Feb 22, 2012
    Developers on the git list pointed out that:
    
      "['which'] output is not machine parseable, and exit code is not
       reliable, across platforms.  It is only meant for consumption
       by human who can read English (or natural language in the
       current locale)."
    
    So rather than use which to determine if a command is available, the
    script now simply checks for errors when calling the potentially
    missing commands.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  4. Cleaned up a final poorly quoted string

    thenigan committed Feb 22, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  5. Changed back to #!/bin/sh

    thenigan committed Feb 22, 2012
    This matches the style used in the other shell scripts bundled with git.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  6. Simplified path concatenation logic per recommendations from the git …

    thenigan committed Feb 22, 2012
    …list
    
    Suggestion for improvement from Junio Hamano.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  7. Cleaned up quoting of variables

    thenigan committed Feb 22, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  8. Improved readability of while loop

    thenigan committed Feb 22, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  9. Corrected indentation error

    thenigan committed Feb 22, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  10. Removed blank line at end of file

    thenigan committed Feb 22, 2012
    This is a considered a whitespace error in git coding guidelines
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Feb 20, 2012
  1. Stop echoing value of $diff_tool on --extcmd

    thenigan committed Feb 20, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  2. Cleaned up opening comments

    thenigan committed Feb 20, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  3. Use tabs for indentation rather than spaces

    thenigan committed Feb 20, 2012
    The git CodingGuidelines state that tabs are preferred.
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
  4. Replaced `` with $() for command substitution

    thenigan committed Feb 20, 2012
    The git CodingGuidelines state that:
    
      "We prefer $( ... ) for command substitution; unlike ``, it
       properly nests.  It should have been the way Bourne spelled
       it from day one, but unfortunately isn't"
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Feb 19, 2012
  1. Updated code style to meet git standards

    thenigan committed Feb 19, 2012
    Based on recent discussions on the git-dev list [1], the preferred style
    for shell scripts has changed.  Changes include:
      - 'test' is preferred over '['
      - 'then' statements should be on a separate line
    
    [1]: http://thread.gmane.org/gmane.comp.version-control.git/190836/focus=190884
    
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>
Commits on Jan 5, 2012
  1. Updated copyright statement for 2012

    thenigan committed Jan 5, 2012
    Signed-off-by: Tim Henigan <tim.henigan@gmail.com>