-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transforms: Reword some paragraphs #27985
Comments
Thanks for opening this issue @T0nci - fully agree with you on this. How does something like this sound for the first paragraph?
Purely a wording suggestion - if you find a different wording more appropriate, by all means shout it out! |
I was just reading through that lesson, when i saw that PR. I don't think those paragraphs interfere with each other. First one is talking about three-dimensional transforms, and the other is talking about matrix functions. I agree though that this first paragraph is unnecessary lengthy |
While they are talking about two different things, I can definitely see how some might have a little uncertainty, and the first paragraphed mentioned is definitely a little lengthy (and mentions what I believe are now-pruned additional resources). If streamlining that one paragraph can make it flow better and eliminate any confusion (without actually changing the substance of the lesson material), then I think it's a good change to make |
@MaoShizhong It looks great to me! @bigacz Oh, that makes much more sense now. Great catch, I thought the second paragraph was referring to all of the above 3D functions and not just the matrix functions. @MaoShizhong Should I still make the change to the first paragraph with the suggestion you made? |
@T0nci I would be happy with streamlining the first paragraph as above. |
Checks
Describe your suggestion
While reading the lesson about transforms I saw something that could need an improvement:
The paragraph in the first screenshot(location: Three-dimensional transforms) should be replaced(and/or completely removed) with the paragraph in the second screenshot(location: Matrix) as they conflict with each other - one states you should get comfortable with the specified functions while the other states that you needn't feel comfortable with them. Additionally the first paragraph states that there are many external resources from here on out, but there aren't many external resources until the Assignment section.
But as English is not my first language I may have misunderstood the meanings of these 2 paragraphs so this is just a suggestion.
Path
Node / JS
Lesson Url
https://www.theodinproject.com/lessons/node-path-advanced-html-and-css-transforms
(Optional) Discord Name
No response
(Optional) Additional Comments
No response
The text was updated successfully, but these errors were encountered: