New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post: Fixing contrib javascript #5

Open
theodoreb opened this Issue Jan 15, 2014 · 3 comments

Comments

Projects
None yet
2 participants
@theodoreb
Owner

theodoreb commented Jan 15, 2014

@theodoreb

This comment has been minimized.

Show comment
Hide comment
@theodoreb

theodoreb Jan 15, 2014

Owner

Sorry about the link spaming, I'll try to have less distracting things for you to look at next time.

Just leaving a comment to show they display directly under the article now, no need to visit the github page to read them :)

Owner

theodoreb commented Jan 15, 2014

Sorry about the link spaming, I'll try to have less distracting things for you to look at next time.

Just leaving a comment to show they display directly under the article now, no need to visit the github page to read them :)

@mikeytown2

This comment has been minimized.

Show comment
Hide comment
@mikeytown2

mikeytown2 Jan 15, 2014

AdvAgg has the validator submodule which can run JSHint on your drupal install. It also has the mod submodule which has an option to not include jQuery if jQuery is not going to be used (jQuery and Drupal JavaScript libraries and settings are output even when no JS is added to the page).

AdvAgg has the validator submodule which can run JSHint on your drupal install. It also has the mod submodule which has an option to not include jQuery if jQuery is not going to be used (jQuery and Drupal JavaScript libraries and settings are output even when no JS is added to the page).

@theodoreb

This comment has been minimized.

Show comment
Hide comment
@theodoreb

theodoreb Jan 15, 2014

Owner

Ooh that's really nice! I didn't know about that. Looks like the patch was close to RTBC for 7 no? Care to do one more review on it so it might make it in core? :)

What I hope happens with JSHint is that it's run before the automated test on the testbot and on projects that have CI set up ; to be able to do that all of core, contrib and custom must validate. The clientside JSHint validation is really neat, could definitely see that in the coder module :D

Owner

theodoreb commented Jan 15, 2014

Ooh that's really nice! I didn't know about that. Looks like the patch was close to RTBC for 7 no? Care to do one more review on it so it might make it in core? :)

What I hope happens with JSHint is that it's run before the automated test on the testbot and on projects that have CI set up ; to be able to do that all of core, contrib and custom must validate. The clientside JSHint validation is really neat, could definitely see that in the coder module :D

@theodoreb theodoreb closed this Apr 26, 2014

@theodoreb theodoreb reopened this Apr 26, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment