Changed getter and setter definitions #23

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@giuliandrimba
Contributor

The problem:

__defineGetter__ and __defineSetter__ were not working on IE9. Besides that, these methods are deprecated according to MDN: https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/defineSetter

Solution:

Use Object.defineProperty instead, as it is ES5 preferred syntax, and works on IE9. https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Object/defineProperty

Owner
arboleya commented Apr 5, 2013

Very nice, I'm going to merge it soon in the edge branch I'm working on.

Thank you 🍻

@arboleya arboleya was assigned Apr 5, 2013
Owner

Since the weather has changed dramatically over the branches salad, I've merged this code manually as comments by now.
b88d5ab

In the very future, when the model will be re-implemented, things will stay tight.

Thank you.

@arboleya arboleya closed this May 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment