Skip to content
This repository

Add Verify command #15

Closed
theory opened this Issue May 21, 2012 · 1 comment

1 participant

David E. Wheeler
David E. Wheeler
Owner
theory commented May 21, 2012

Will run all scripts in the verify directory that correspond to currently-deployed changes. For reworked changes, only the most recent instance of the script should be run.

Also add a --verify option to deploy and rebase that will verify each step after it is deployed, and optionally roll back if the verify fails.

The thing that runs the scripts will vary by engine, but should be a reasonable default that can be replaced by a config variables. A verify script will be considered to have failed it the command does not return success (exitval 0).

David E. Wheeler theory referenced this issue from a commit December 26, 2012
David E. Wheeler Add `verify_change()` to Engine.
Called by `deploy_change()` if the new `with_verify` attribute is true. If the
verify fails, the deploy will be considered to have failed and the revert
process will start. If the change has no verify script a message will be sent
to STDERR but the deploy will not be considered a failure (for now). Verify
scripts will still run in log-only mode. Ref #15.
d4c4e72
David E. Wheeler theory referenced this issue from a commit December 27, 2012
David E. Wheeler First pass at `verify()`.
I have most of the logic I want in there. I think it's pretty good. Will start
on tests next, as there are likely a bazillion bugs. Ref #15.
a966ef3
David E. Wheeler theory referenced this issue from a commit December 28, 2012
David E. Wheeler Complete testing and implementation of verify().
Next up, adding the command. Ref #15.
5cde227
David E. Wheeler
Owner

Finally added the verify command itself in 2283d09. I think the only thing that still needs doing is to make sure that reworked changes are handled properly: I don't think earlier verify scripts should be run.

David E. Wheeler theory closed this December 28, 2012
David E. Wheeler theory referenced this issue from a commit December 28, 2012
David E. Wheeler Skip verification for reworked changes.
Last knonw issue in issue #15.
749b900
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.