New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use warnings and fix spelling test #11

Merged
merged 1 commit into from Feb 5, 2015

Conversation

Projects
None yet
2 participants
@lucaskanashiro
Contributor

lucaskanashiro commented Feb 4, 2015

  • Added 'use warnings' in all Perl files
  • Fix a POD spelling test
@theory

This comment has been minimized.

Owner

theory commented Feb 4, 2015

I see no need for this.

@lucaskanashiro

This comment has been minimized.

Contributor

lucaskanashiro commented Feb 4, 2015

No need for the addition of 'use warnings'? Or the spelling test?
With warnings I tried to make a little improvement based in one CPAN extra metric (http://cpants.cpanauthors.org/dist/Text-Markup), are you think that it's not necessary?
I executed the suite test and the POD spelling test are failing here, I only added another stop word to pass it.

@theory

This comment has been minimized.

Owner

theory commented Feb 4, 2015

The spelling fix is fine, but there is no need for use warnings; in the code. It can be nice to have when doing diagnostics, but isn't necessary in shipping code, IMO, especially since warnings are enabled in the tests.

@lucaskanashiro

This comment has been minimized.

Contributor

lucaskanashiro commented Feb 5, 2015

OK @theory ! I will reset the 'use warnings;' commit and leave only the spelling fix.

Fixed spelling test
Added 'Daniele' in stop word list
@lucaskanashiro

This comment has been minimized.

Contributor

lucaskanashiro commented Feb 5, 2015

Done.

@theory theory merged commit 7c70896 into theory:master Feb 5, 2015

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment