New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `raw` option where possible [#2] #24

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@genehack
Contributor

genehack commented Apr 17, 2016

This adds a raw option that can be passed to parse() that causes the
parser to return the raw output of the underlying layer, without
wrapping in the minimal HTML skeleton.

This is only possible for a subset of the existing parsers; this patch
makes no attempt to remove the HTML wrappers in the cases where that
wrapper is being added by the underlying parser.

Note also that this patch does not add any tests for this new behavior,
because there don't appear to be any cases where input/output
transformations are actually being currently tested.

Add `raw` option where possible [#2]
This adds a `raw` option that can be passed to `parse()` that causes the
parser to return the raw output of the underlying layer, without
wrapping in the minimal HTML skeleton.

This is only possible for a subset of the existing parsers; this patch
makes no attempt to remove the HTML wrappers in the cases where that
wrapper is being added by the underlying parser.

Note also that this patch does not add any tests for this new behavior,
because there don't appear to be any cases where input/output
transformations are actually being currently tested.
@theory

This comment has been minimized.

Show comment
Hide comment
@theory

theory May 10, 2016

Owner

Cherry-picked in 2d3352c. However I think it needs some docs. Can you add them, @genehack?

Owner

theory commented May 10, 2016

Cherry-picked in 2d3352c. However I think it needs some docs. Can you add them, @genehack?

@theory theory closed this May 10, 2016

@genehack

This comment has been minimized.

Show comment
Hide comment
@genehack

genehack May 11, 2016

Contributor

Yep, I can work on docs for this -- give me a few days, I'll send another PR.

Contributor

genehack commented May 11, 2016

Yep, I can work on docs for this -- give me a few days, I'll send another PR.

@theory

This comment has been minimized.

Show comment
Hide comment
@theory

theory May 11, 2016

Owner

Thanks @genehack@

Owner

theory commented May 11, 2016

Thanks @genehack@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment