New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not build with SBCL 1.2.2 #1

Closed
quicklisp opened this Issue Aug 12, 2014 · 10 comments

Comments

Projects
None yet
4 participants

@thephoeron thephoeron added the bug label Aug 12, 2014

@thephoeron

This comment has been minimized.

Show comment
Hide comment
@thephoeron

thephoeron Aug 12, 2014

Owner

I was afraid this would happen, with the internal changes made in 1.2.2; I'm still using 1.2.0-1—the latest in the Arch repos—so I haven't been able to test for this yet, but it looks to be what I expected.

When would you like this fixed by, for the next Quicklisp release?

Owner

thephoeron commented Aug 12, 2014

I was afraid this would happen, with the internal changes made in 1.2.2; I'm still using 1.2.0-1—the latest in the Arch repos—so I haven't been able to test for this yet, but it looks to be what I expected.

When would you like this fixed by, for the next Quicklisp release?

@quicklisp

This comment has been minimized.

Show comment
Hide comment
@quicklisp

quicklisp Aug 12, 2014

I'm hoping to make a release in a few days, on Saturday or Sunday.

quicklisp commented Aug 12, 2014

I'm hoping to make a release in a few days, on Saturday or Sunday.

@thephoeron

This comment has been minimized.

Show comment
Hide comment
@thephoeron

thephoeron Aug 12, 2014

Owner

Ok! I'll work on this today.

Owner

thephoeron commented Aug 12, 2014

Ok! I'll work on this today.

@thephoeron

This comment has been minimized.

Show comment
Hide comment
@thephoeron

thephoeron Aug 12, 2014

Owner

The suggestion on Reddit by vi111 didn't seem to fix the problem (re: commit cccfefa), so I've temporarily disabled DEFMACRO! and related code until a better solution can be found. I will leave this issue open until then.

Does it build for you now?

Owner

thephoeron commented Aug 12, 2014

The suggestion on Reddit by vi111 didn't seem to fix the problem (re: commit cccfefa), so I've temporarily disabled DEFMACRO! and related code until a better solution can be found. I will leave this issue open until then.

Does it build for you now?

@fare

This comment has been minimized.

Show comment
Hide comment
@fare

fare Aug 13, 2014

If for some reason you really need a traditional backquote that expands to lists only, try fare-quasiquote: it's based on the previous SBCL implementation, just with the recently discovered bugs fixed (and an extensive test suite) rather than a reimplementation.

fare commented Aug 13, 2014

If for some reason you really need a traditional backquote that expands to lists only, try fare-quasiquote: it's based on the previous SBCL implementation, just with the recently discovered bugs fixed (and an extensive test suite) rather than a reimplementation.

@thephoeron

This comment has been minimized.

Show comment
Hide comment
@thephoeron

thephoeron Aug 13, 2014

Owner

Thanks @fare, I'll check that out — I would like to keep the code as similar to Doug Hoyte's source as possible, since this lib is just meant as a reference implementation for readers of his book.

Owner

thephoeron commented Aug 13, 2014

Thanks @fare, I'll check that out — I would like to keep the code as similar to Doug Hoyte's source as possible, since this lib is just meant as a reference implementation for readers of his book.

@orivej

This comment has been minimized.

Show comment
Hide comment
@orivej

orivej Aug 14, 2014

@thephoeron, the fix in cccfefa did not work because you test for sb-impl::comma, which is an atom, after you test for atom.

And it should be (rec (sb-impl::comma-expr x) acc) not (cons (sb-impl::comma-expr x) acc).

orivej commented Aug 14, 2014

@thephoeron, the fix in cccfefa did not work because you test for sb-impl::comma, which is an atom, after you test for atom.

And it should be (rec (sb-impl::comma-expr x) acc) not (cons (sb-impl::comma-expr x) acc).

thephoeron added a commit that referenced this issue Aug 14, 2014

thephoeron added a commit that referenced this issue Aug 14, 2014

@thephoeron

This comment has been minimized.

Show comment
Hide comment
@thephoeron

thephoeron Aug 14, 2014

Owner

Thanks @orivej — that solved it.

@quicklisp: it should be good to go for the August Quicklisp release, full functionality restored.

Owner

thephoeron commented Aug 14, 2014

Thanks @orivej — that solved it.

@quicklisp: it should be good to go for the August Quicklisp release, full functionality restored.

@thephoeron thephoeron closed this Aug 14, 2014

@orivej

This comment has been minimized.

Show comment
Hide comment
@orivej

orivej Aug 20, 2014

Oops, #-safe-sbcl is also true under CCL and other Lisps where there is no SB-IMPL package!

orivej commented Aug 20, 2014

Oops, #-safe-sbcl is also true under CCL and other Lisps where there is no SB-IMPL package!

@thephoeron

This comment has been minimized.

Show comment
Hide comment
@thephoeron

thephoeron Aug 20, 2014

Owner

Of course. Commit a202167 should do it.

Owner

thephoeron commented Aug 20, 2014

Of course. Commit a202167 should do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment