Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Override the createFromPath static method for a simple open mode on Reader #266
I actually got bit by the readonly issue that is described in #258 And figured I'd give a shot at how to fix the issue.
I introduce a new static method in reader where the default open mode is 'r'. I also added a test to ensure this works by adding a readonly csv file.
Describe the new/upated/fixed feature
I override the static function
Backward Incompatible Changes
There shouldn't be a BC issue.
Targeted release version
Could be 9.0, 10.0, up to you. This is my first time writing a PR for a PHP library like this so its very much a learning experience for me
I don't think there should be a PR impact.