New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding EscapeFormulaInjection formatter #269

Merged
merged 3 commits into from Oct 17, 2017

Conversation

Projects
None yet
2 participants
@nyamsprod
Member

nyamsprod commented Oct 16, 2017

view #268

@nyamsprod

This comment has been minimized.

Show comment
Hide comment
@nyamsprod

nyamsprod Oct 16, 2017

Member

@klaude here's a POC which works so it was simple to add But I'm still skeptical in its usefulness and/or binding it to the package

Member

nyamsprod commented Oct 16, 2017

@klaude here's a POC which works so it was simple to add But I'm still skeptical in its usefulness and/or binding it to the package

@klaude klaude referenced this pull request Oct 16, 2017

Closed

Preventing CSV Injection #268

@klaude

This comment has been minimized.

Show comment
Hide comment
@klaude

klaude Oct 16, 2017

That looks good to me. I think the only difference between this and what I was envisioning was a constructor argument to say which columns to escape, but this suits my purposes at work just fine.

klaude commented Oct 16, 2017

That looks good to me. I think the only difference between this and what I was envisioning was a constructor argument to say which columns to escape, but this suits my purposes at work just fine.

@nyamsprod nyamsprod merged commit 04bb837 into master Oct 17, 2017

3 checks passed

Scrutinizer 9 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@nyamsprod nyamsprod deleted the feature/formula-injection branch Oct 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment