New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses Issue #94 #95

Merged
merged 1 commit into from Sep 16, 2017

Conversation

Projects
None yet
2 participants
@stevendesu
Contributor

stevendesu commented Mar 11, 2017

I went ahead and wrapped this up to address my own issue

@Nyholm

This comment has been minimized.

Show comment
Hide comment
@Nyholm

Nyholm Sep 6, 2017

Collaborator

Thank you. Could you rebase this and check why the tests fails?

Collaborator

Nyholm commented Sep 6, 2017

Thank you. Could you rebase this and check why the tests fails?

@stevendesu

This comment has been minimized.

Show comment
Hide comment
@stevendesu

stevendesu Sep 9, 2017

Contributor

Will rebase and start to look into this tonight or tomorrow.

Contributor

stevendesu commented Sep 9, 2017

Will rebase and start to look into this tonight or tomorrow.

@Nyholm

This comment has been minimized.

Show comment
Hide comment
@Nyholm

Nyholm Sep 13, 2017

Collaborator

Awesome. Thank you.

Collaborator

Nyholm commented Sep 13, 2017

Awesome. Thank you.

@stevendesu

This comment has been minimized.

Show comment
Hide comment
@stevendesu

stevendesu Sep 14, 2017

Contributor

This has been rebased onto master. Pending unit tests

Contributor

stevendesu commented Sep 14, 2017

This has been rebased onto master. Pending unit tests

@Nyholm

Nyholm approved these changes Sep 16, 2017

@Nyholm Nyholm merged commit 511dbef into thephpleague:master Sep 16, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment