Add graceful handling of cache write failure due to already existent cache file caused by race condition. #39

Merged
merged 1 commit into from Feb 26, 2015

Conversation

Projects
None yet
2 participants
@kevin-thackorie

These changes address the concurrent cache write issue revealed by #38.

Kevin Thackorie
@kevin-thackorie

This comment has been minimized.

Show comment
Hide comment
@kevin-thackorie

kevin-thackorie Feb 26, 2015

It looks like something is wrong with Scrutinizer. Perhaps Travis didn't finish in time to report code coverage?:

The code coverage data was not received within the specified time. Please make sure your third-party service is configured to send code coverage data.

It looks like something is wrong with Scrutinizer. Perhaps Travis didn't finish in time to report code coverage?:

The code coverage data was not received within the specified time. Please make sure your third-party service is configured to send code coverage data.

@reinink

This comment has been minimized.

Show comment
Hide comment
@reinink

reinink Feb 26, 2015

Member

Yeah, I just reran the tests and everything looks cool. Thanks for putting this together Kevin!

Member

reinink commented Feb 26, 2015

Yeah, I just reran the tests and everything looks cool. Thanks for putting this together Kevin!

reinink added a commit that referenced this pull request Feb 26, 2015

Merge pull request #39 from kevin-thackorie/concurrentCacheFile
Add graceful handling of cache write failure due to already existent cache file caused by race condition.

@reinink reinink merged commit abf2864 into thephpleague:master Feb 26, 2015

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@kevin-thackorie kevin-thackorie deleted the kevin-thackorie:concurrentCacheFile branch Feb 26, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment