A bunch of stuff for Travis CI #40
Conversation
There's an issue with 2.0 and the versions of the laravel packages, intervention states that it supports a lower version than it does, which can lead to failures if users are on those versions.
|
It looks like there's another lowest dependency issue (only showing on hhvm), but I'm not sure which package is the culprit, |
|
Wow @duncan3dc, this is awesome! Thanks so much for putting this together. We just need to figure out that HHVM issue. I did a quick Google search, and found this. Makes me wonder if this is related to GD. Although that doesn't make a ton of sense, since that test is mocked out pretty heavily. I'll have to do some digging. |
|
Cool, I'm happy to help. I have an hhvm instance at home so I'll do some checking myself next time I get chance, if you don't beat me to the solution :) |
|
It looks like the problem is Do you know why this particular test is run under this condition? The commit (dac2c96) doesn't mention it. |
This is because @runInSeparateProcess has a bug in hhvm for versions prior to this
|
Adding a requirement for There are a few issues reporting this: And the resolution seems to just be "use a more up to date version". Are you happy to list the |
|
If I recall correctly, the |
|
Thanks again for your work on this @duncan3dc, much appreciated! |
|
Thanks for your work on producing this cool library 👍 |
| "league/flysystem": "~1.0", | ||
| "symfony/http-foundation": "~2.3", | ||
| "symfony/http-kernel": "~2.3" | ||
| }, | ||
| "require-dev": { | ||
| "mockery/mockery": "~0.9", | ||
| "phpunit/php-token-stream": ">=1.3.0", |
There was a problem hiding this comment.
Don't use unbound version constraints.
There was a problem hiding this comment.
It's not really a good point, as the dependency is only relevant for phpunit, which has a bounded version constraint, so we don't care what version of php-token-stream we get, as long as it's above 1.3.0, and compatible with our ~4.4 of phpunit, which composer takes care of
composer updateto test against the highest dependenciesDoing this uncovered an issue in the dependencies. This looks like a problem in
intervention/image, where they are misstating their lowest supported dependencies. Bumping glide's supported version to~2.1fixes that but I'm not sure whether you'd rather pursue a fix with intervention instead.