New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Discord link to actively maintained third-party client #663

Merged
merged 1 commit into from Jan 13, 2018

Conversation

Projects
None yet
2 participants
@wohali
Contributor

wohali commented Oct 15, 2017

Greetings!

Sadly, the currently linked Discord client appears to be abandoned for over a year. PRs and issues filed on the repo are never addressed by a committer, or are closed without comment. The implementation is also incompatible with the League's 2.x oauth2-client releases. Finally, the maintainer's other major Discord-related PHP project has recently been marked as abandoned.

I have fully re-implemented the Discord provider from scratch, compatible with the 2.x oauth2-client. I followed the example of the first-party clients (thanks team!) I have striven to meet the same first-party code quality expectations: tests provide 100% code coverage, Scrutinizer gives the code quality a 10, and there are no lint errors using the same settings as the main oauth2-client itself.

Please consider this PR.

I should also like to submit this client for consideration as a potential to be merged into the League's organization, as a first-party client.

@ramsey

This comment has been minimized.

Show comment
Hide comment
@ramsey

ramsey Jan 13, 2018

Contributor

Thank you for contributing! 🎉

Looks great. I might recommend that you change your package name from wohali/oauth2-discord-new to wohali/oauth2-discord (without the -new), but that's up to you.

Contributor

ramsey commented Jan 13, 2018

Thank you for contributing! 🎉

Looks great. I might recommend that you change your package name from wohali/oauth2-discord-new to wohali/oauth2-discord (without the -new), but that's up to you.

@ramsey ramsey merged commit 657d5bb into thephpleague:master Jan 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment